Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please properly fork instead of stealing the codebase #10

Closed
forrestbao opened this issue Mar 19, 2023 · 22 comments
Closed

Please properly fork instead of stealing the codebase #10

forrestbao opened this issue Mar 19, 2023 · 22 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested

Comments

@forrestbao
Copy link

Hi, the code base is obviously from https://github.com/TexteaInc/json-viewer which was copyrighted by Textea Inc. You pulled the codebase and re-uploaded here. Ironically, you included all the commit history. Please stop stealing the copyrighted code. If you want to develop your own fork, please properly fork the codebase.

@mashirozx
Copy link

MIT License

Copyright (c) 2022 Textea, Inc.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.

https://github.com/TexteaInc/json-viewer/blob/main/LICENSE

@himself65 himself65 added help wanted Extra attention is needed good first issue Good for newcomers question Further information is requested labels Mar 19, 2023
@himself65
Copy link
Owner

I do not want to explain any more about this. But ironically, here we have someone did nothing on the codespace but still wants to own the codespace.

@septs
Copy link

septs commented Mar 19, 2023

1st maintainer is ?

https://github.com/TexteaInc/json-viewer/graphs/contributors

@forrestbao
Copy link
Author

Thank you @mashirozx. I'd encourage @himself65 to make a proper fork from the original repo. Initiating a repo from the complete history of another repo is usually not accepted in the community. Allow me to highlight the license term:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

@mashirozx
Copy link

have you received the salary?🫣 @himself65

@forrestbao
Copy link
Author

forrestbao commented Mar 19, 2023

I'd recommend you to consult with a lawyer and ask him/her whether the code you developed as an employee of a company belongs to you or the company? And please ask him/her to explain the MIT license to you.

I do not want to explain any more about this. But ironically, here we have someone did nothing on the codespace but still wants to own the codespace.

@forrestbao
Copy link
Author

If there were no company called Github in the world that invented an operation called fork, how would you maintain an abandoned project? After all, you don't allow maintainers to create a new repository, even though this is allowed by the MIT license.

Please read the MIT license:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

@forrestbao
Copy link
Author

shall include this https://github.com/mac-s-g/react-json-view/blob/master/LICENSE in TexteaInc/json-viewer?

Ah, I really recommend you to talk to an IP/copyright lawyer. How many line's of code in Mac-s-g's JSON-viewer are included in Textea's JSON-Viewer? Even the very initial commit? And, Textea's JSon-view acknowledged mac-s-g's. What about the repo here? Does it do the same? Please be gentlemen in the open source community.

The situation here is different. Here every line and every commit is copied. Ironically, my commit, a simple one, is included.

@Justineo
Copy link

Justineo commented Mar 19, 2023

Isn’t the original license already included in this repo? 😅

https://github.com/Himself65/data-viewer/blob/8aeba0a50a49e2b148d9d796c0ae07cfec435300/LICENSE#L4

I also don't understand what a project's compliance with the MIT license has to do with whether it includes the git history and how many lines of code it “copies”…

@wang-boyu
Copy link

Adding Textea, Inc. to the license file should have fixed this issue. Copying the code without forking it shouldn't be a problem.

On a side note, it's better to add the original author from mac-s-g/react-json-view back into the license file in TexteaInc/json-viewer, per MIT license, since TexteaInc insists on such strict enforcement.

@himself65 himself65 pinned this issue Mar 19, 2023
@forrestbao forrestbao changed the title Please properly forking instead of stealing the codebase Please properly fork instead of stealing the codebase Mar 19, 2023
@forrestbao
Copy link
Author

Adding Textea, Inc. to the license file should have fixed this issue. Copying the code without forking it shouldn't be a problem.

On a side note, it's better to add the original author from mac-s-g/react-json-view back into the license file in TexteaInc/json-viewer, per MIT license, since TexteaInc insists on such strict enforcement.

Good suggestion. mac-s-g's credit has always been clearly acknowledged and saluted at TexteaInc/json-viewer.
But I am not sure whether he should be mentioned in the copyright notice. According to what @himself65 told me, he completely overhauled mac-s-g's code.

So I will leave this to @himself65. He can make a PR in TexteaInc/json-viewer and we will merge it. And I'd expect the same in this repo.

@forrestbao
Copy link
Author

Isn’t the original license already included in this repo? sweat_smile

https://github.com/Himself65/data-viewer/blob/8aeba0a50a49e2b148d9d796c0ae07cfec435300/LICENSE#L4

My bad. I didn't realize it earlier. Thanks for pointing out.

@jhdxr
Copy link

jhdxr commented Mar 19, 2023

I have to say this issue refreshed (once again) my awareness of how low the level of a CS professor can be. (even for an assistant professor)

@forrestbao
Copy link
Author

I have to say this issue refreshed (once again) my awareness of how low the level of a CS professor can be. (even for an assistant professor)

Yes, I admit, I am the stupid guy here. I did not check the license carefully.

@Aloento
Copy link

Aloento commented Mar 19, 2023

圣地巡礼

@Germxu
Copy link

Germxu commented Mar 19, 2023

So cool this issue. 😅
https://www.ratemyprofessors.com/professor/2466282

@himself65
Copy link
Owner

I started and maintained JSon Viewer while I was the CTO at Textea. As the author and major maintainer of Json viewer, I am receiving requests about Json viewer all the time, so I decided to start working on data viewer, aiming to be a better version of its predecessor.
My time at Textea wasn't pleasant. In fact, up to this message, Textea still owes me one month of salary and a public apology for previous defamation.
While I will try my best to work on data viewer as a response to the community's voice, I hope Textea fulfills its duty and promise as soon as possible, pays wages, and invests time and energy in maintaining JSON Viewer so as not to disappoint users and not to make open source toxic.

@himself65 himself65 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2023
@himself65 himself65 unpinned this issue Mar 19, 2023
@himself65
Copy link
Owner

This is my final warning. You were the first one who chose to defame your partner and our start-up in public. This whole disgraceful process made by you were all well documented. You'd better pay your wages and do your apology as you should.

image

@mashirozx
Copy link

Why not ask help from DOL?😶‍🌫️

@xiaoliwang
Copy link

interesting

@purerosefallen
Copy link

MIT license, and even AGPLv3 license, does not require the downstream distributions use GitHub's fork button. Any forms of open source, including publishing a zip file containing the code, is considered open source.
Fork, or even Git itself, is something introduced later, has no relationship with open source license obligations.

@Naville
Copy link

Naville commented Apr 21, 2023

Am I misunderstanding something or Mr.Bao's startup's leading product is a json viewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests