Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to Bind to single IP #10

Closed
andrewkro opened this issue Oct 18, 2012 · 2 comments
Closed

Possible to Bind to single IP #10

andrewkro opened this issue Oct 18, 2012 · 2 comments
Assignees
@dmp42
Labels
enhancement in progress
Milestone
0.4

Comments

@andrewkro
Copy link

Would it be possible to add a config.address parameter allowing you to specify a specific port to bind to?

Ive made the change on my local, in worker.js, lines 351 and 368 to:

ipv4HttpServer.listen(config.port, config.address);
...
ipv4HttpsServer.listen(config.https.port, config.https.address);

Might be useful for others.

Andrew
@jpetazzo
Copy link
Contributor

This is a good idea. It would be an interesting enhancement, and it is easy to implement.

We have no plan to work on that in the short term (since our production Hipache cluster is on EC2, and EC2 supports only 1 IP address per machine), but this would be a low hanging fruit if someone wants to contribute some code.

@jpetazzo jpetazzo mentioned this issue Mar 21, 2013
Closed
@dmp42 dmp42 added this to the 0.4 milestone Mar 20, 2014
@dmp42 dmp42 self-assigned this Mar 20, 2014
dmp42 pushed a commit that referenced this issue Apr 21, 2014
Config && dry-run work
70016ab 
- now sports a config class that can do all sort of magic / preparation / legacy handling
- new command line flag -d (--dry) that just tries to load the config and exit (will catch a number of config errors, although not all) - need extra work
- new http / https configuration syntax that allows binding individually on any number of ips / port, with specific certificates
- fixes #4 (but not SNI yet)
- fixes #10
- on the road to fix #122
@dmp42 dmp42 mentioned this issue Apr 21, 2014
Closed
@dmp42 dmp42 closed this as completed in 57d2e3c Apr 29, 2014
@dmp42
Copy link
Member

dmp42 commented Apr 29, 2014

It's on master (-> 0.4) (#143).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmp42 dmp42

Labels
enhancement in progress
Projects
None yet
Milestone
0.4
Development

No branches or pull requests
3 participants
@jpetazzo @dmp42 @andrewkro