Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make moon eccentricity optional free parameter #9

Closed
hippke opened this issue Oct 23, 2021 · 3 comments
Closed

Make moon eccentricity optional free parameter #9

hippke opened this issue Oct 23, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@hippke
Copy link
Owner

hippke commented Oct 23, 2021

No description provided.

@hippke hippke added the enhancement New feature or request label Oct 23, 2021
@hippke hippke changed the title Make moon eccentricity possible Make moon eccentricity optional free parameter Oct 23, 2021
@hippke
Copy link
Owner Author

hippke commented Oct 24, 2021

also include $w$ Argument of periapsis

@hippke
Copy link
Owner Author

hippke commented Oct 24, 2021

Function available as ellipse_pos_eccentricity(a, per, e, tau, Omega, w, i, time)
Still needed:

  • Optional parameter in pandora main module
  • Testing

@reneheller
Copy link
Collaborator

Agreed that it's best to allow e > 0 but use e = 0 by default. Justification (tidal circularization, unconstrained MCMC sampling) to be added to the paper.

@hippke hippke closed this as completed Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@reneheller @hippke