Skip to content
This repository has been archived by the owner on Apr 8, 2022. It is now read-only.

Explicitly send X-Plex-Token as URL parameter (Kodi 17.0b6-Krypton) #181

Closed

Conversation

gritstub
Copy link

As of Kodi 17.0b6-Krypton [1], curl will no longer send all headers blindly.

This results in (at least) thumbnails not loading, and errors:

DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option ' X-Plex-Platform: KODI'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Client-Identifier: ...'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Client-Platform: KODI'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Device: PleXBMC'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Device-Name: My PleXBMC Client'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Language: en'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Model: unknown'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Platform-Version: Windows'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Product: PleXBMC'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Provides: player'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Token: ...'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-User: ...'
DEBUG: CurlFile::ParseAndCorrectUrl() ignoring header option 'X-Plex-Version: 4.1.0'
ERROR: CCurlFile::Stat - Failed: HTTP response code said error(22) for https://192.168.1.2:32400/photo/:/transcode?url=http%3A%2F%2Flocalhost%3A32400%2Flibrary%2Fmetadata%2F3%2Fthumb%2F1427952599&width=720&height=720 | X-Plex-Platform=KODI&X-Plex-Client-Platform=KODI&X-Plex-User=...&X-Plex-Device-Name=My%20PleXBMC%20Client&X-Plex-Provides=player&X-Plex-Token=...&X-Plex-Model=unknown&X-Plex-Platform-Version=Windows&X-Plex-Client-Identifier=...&X-Plex-Device=PleXBMC&X-Plex-Product=PleXBMC&X-Plex-Language=en&X-Plex-Version=4.1.0

This patch adds the token as a URL Parameter [2] of the URL returned from get_kodi_header_formatted_url

Not sure if this is the correct branch to base this pull request on.

References:
[1] xbmc/xbmc@ed00cd6
[2] https://support.plex.tv/hc/en-us/articles/204059436-Finding-your-account-token-X-Plex-Token

@gritstub gritstub closed this Dec 17, 2016
@gritstub gritstub reopened this Dec 17, 2016
@Tomalak
Copy link

Tomalak commented Feb 12, 2017

I can confirm the issue, but I'm pretty sure that isengard-helper-merge is not the right merge target. I think it should be helix.

Then again I am not sure if there is still anything happening at all in this project. :(

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants