-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
int_to_unit and float_to_unit break if max == min #17
Comments
I think it is silly to have the code break when it would be much better to return an error message. However, I can't think of a good reason why anyone would set |
I don't have a good reason, but I do have a bad reason! (laziness) One example would be that I'm trying to optimize multiple hyperparameters at once. Later, I want to run the same optimization, but fix one of the parameters rather than optimizing over it. If I can set I tried hacking it in by having a check here: Spearmint/spearmint/tasks/base_task.py Line 375 in 3b0f241
and then setting unit to zero if vmin == vmax . This runs, but I don't understand the code well enough to know if this will break any of the GP stuff down the line. Do you think something like this would work?
I can make a PR with at least a better warning. |
Hi Jesse, yeah I understand that. It would require building in some logic I'd rather leave that kind of bookkeeping up to the user than try to build Definitely a better warning would be great :-) I added a more useful Jasper On Mon, May 11, 2015 at 7:24 PM, Jesse Livezey notifications@github.com
|
I think if you remove the parameter from the config entirely then everything should be ok, but as you said your code would need to know that this parameter is not coming in. I agree with Jasper's assessment. Mike |
Thanks for the feedback! I'm probably also going to write something that just filters out parameters with trivial ranges and adds them back in at the end. Once I get it working, I'll post it here in case it's useful for others. |
That sounds great! Cheers, Jasper On Wed, Jun 3, 2015 at 8:23 PM, Jesse Livezey notifications@github.com
|
In
spearmint/tasks/base_task.py
, the functionsint_to_unit
andfloat_to_unit
assume thatvmax > vmin
. When running experiments with trivial parameter ranges (vmax == vmin
), this breaks when I think the reasonable behavior is to just always choose the one value.Spearmint/spearmint/tasks/base_task.py
Line 372 in 92d6b5d
The text was updated successfully, but these errors were encountered: