You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm splitting out one point of discussion from #30 : we should have a strategy how to handle different dtypes (int, float) and when conversions occur. This is a reminder issue for @adl1995 to write a small docs page describing the behaviour and to add tests asserting it.
At the moment it looks like the scikit-image transform we call always outputs floats, it can't output ints directly (this kinda makes sense, interpolation methods usually need floats as far as I know).
So for now, we're calling with preserve_range=True, which gives back float64 with roughly the same values as the input int16 image in our FITS test case.
preserve_range : bool, optional
Whether to keep the original range of values. Otherwise, the input image is converted according to the conventions of img_as_float.
There's several things to discuss / decide here, namely whether to convert to float32 by default to save space and avoid the float64, whether to provide options in hips to convert back to int images, or whether to only document to users how to do that, ...
The text was updated successfully, but these errors were encountered:
I'm splitting out one point of discussion from #30 : we should have a strategy how to handle different dtypes (int, float) and when conversions occur. This is a reminder issue for @adl1995 to write a small docs page describing the behaviour and to add tests asserting it.
At the moment it looks like the scikit-image transform we call always outputs floats, it can't output ints directly (this kinda makes sense, interpolation methods usually need floats as far as I know).
So for now, we're calling with
preserve_range=True
, which gives backfloat64
with roughly the same values as the inputint16
image in our FITS test case.There's several things to discuss / decide here, namely whether to convert to
float32
by default to save space and avoid thefloat64
, whether to provide options inhips
to convert back toint
images, or whether to only document to users how to do that, ...The text was updated successfully, but these errors were encountered: