Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

href property is not defined on type RouteLocation #1

Open
jermsam opened this issue May 11, 2023 · 0 comments
Open

href property is not defined on type RouteLocation #1

jermsam opened this issue May 11, 2023 · 0 comments

Comments

@jermsam
Copy link

jermsam commented May 11, 2023

In router-head.tsx on line 17;
Instead of href={loc.href}, we should have href={loc.url.href} since RouteLocation is defined as:

export interface RouteLocation {
  /**
   * Route params extracted from the URL.
   */
  readonly params: Record<string, string>;
  /**
   * The current URL.
   */
  readonly url: URL;
  /**
   * True if the app is currently navigating.
   */
  readonly isNavigating: boolean;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant