Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make action buttons from TxListTabs semantic and aligned #1195

Conversation

raphaeljp
Copy link
Contributor

Fixes #1188

@vercel
Copy link

vercel bot commented Jun 23, 2023

@raphaeljp is attempting to deploy a commit to the Hiro Systems Team on Vercel.

A member of the Team first needs to authorize it.

@raphaeljp
Copy link
Contributor Author

@andresgalante this PR works fine now.

Copy link

@yashhhguptaaa yashhhguptaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andresgalante for offering me to review the PR.
LGTM

Copy link
Member

@andresgalante andresgalante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @raphaeljp !! 🎉 great contribution!

@He1DAr I build this branch, and it should be ok.

Please, when you have a min give it a try and ship it

@vercel
Copy link

vercel bot commented Jun 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2023 7:39pm

@He1DAr
Copy link
Collaborator

He1DAr commented Jun 28, 2023

@raphaeljp Awesome work, thank you for the PR! Can you please fix the Commitlint checks? Also, the dark mode has less contrast which may affect accessibility.
Before:
image
After:
image

@andresgalante
Copy link
Member

@raphaeljp please make sure to squash your commits with the next change so we are able to merge this PR

@He1DAr
Copy link
Collaborator

He1DAr commented Jul 5, 2023

LGTM! We can ship once Commitlint is fixed.

@raphaeljp raphaeljp force-pushed the fix/export_and_filter_buttons_placement_and_semantics branch from 83de8f7 to 1dd8958 Compare July 5, 2023 13:45
@raphaeljp
Copy link
Contributor Author

@He1DAr both the dark mode contrast and the commitLint are fixed now.

@He1DAr
Copy link
Collaborator

He1DAr commented Jul 5, 2023

@raphaeljp could you please squish all commits into 1 commit with a message: fix: make action buttons from TxListTabs semantic and aligned?

@raphaeljp raphaeljp force-pushed the fix/export_and_filter_buttons_placement_and_semantics branch from 1dd8958 to 46d607c Compare July 5, 2023 23:33
@raphaeljp
Copy link
Contributor Author

@raphaeljp could you please squish all commits into 1 commit with a message: fix: make action buttons from TxListTabs semantic and aligned?

Done :)

@He1DAr He1DAr merged commit 45284ad into hirosystems:main Jul 6, 2023
2 of 3 checks passed
@blockstack-devops
Copy link

🎉 This PR is included in version 1.110.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The Export CSV btn is out of place
5 participants