Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/improve perf #777

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Fix/improve perf #777

merged 1 commit into from
Jul 25, 2022

Conversation

beguene
Copy link
Member

@beguene beguene commented Jul 7, 2022 •
edited

This PR addresses #776

Many server side queries are now moved client-side (except for 1 to keep our SEO health unchanged: page title, meta, nojs bot etc..)
Some other improvements

  • Improve caching, delay fetching and rendering below the fold
  • Remove jotai-query-toolkit in some pages
  • remove dead code

The following pages have been improved

  • /txid
  • /address
  • /block
  • /blocks
  • / (homepage)

Pending

  • e2e regression tests
  • skeleton

@vercel
Copy link

vercel bot commented Jul 7, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
explorer ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 0:50AM (UTC)
hiro-explorer ✅ Ready (Inspect) Visit Preview Jul 22, 2022 at 0:50AM (UTC)

@beguene beguene linked an issue Jul 7, 2022 that may be closed by this pull request
Improve performance for top pages #776
Closed
5 tasks
@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited

Deploy preview for hiro-explorer ready!

✅ Preview
https://hiro-explorer-qhpi8y006-blockstack.vercel.app

Built with commit 103c49e.
This pull request is being automatically deployed with vercel-action

@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited

🌎 https://explorer-git-prod-reference-blockstack.vercel.app/?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 55
🟠 accessibility 82
🟠 best-practices 80
🟠 seo 77
🔴 pwa 42

🌎 https://explorer-git-prod-reference-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 51
🟠 accessibility 88
🟠 best-practices 80
🟠 seo 77
🔴 pwa 42

🌎 https://explorer-git-prod-reference-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 64
🟠 accessibility 89
🟠 best-practices 80
🟠 seo 77
🔴 pwa 42

🌎 https://explorer-git-prod-reference-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 64
🟠 accessibility 89
🟠 best-practices 80
🟠 seo 76
🔴 pwa 42

🌎 https://hiro-explorer-qhpi8y006-blockstack.vercel.app/?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 66
🟠 accessibility 82
🟠 best-practices 87
🟠 seo 76
🔴 pwa 42

🌎 https://hiro-explorer-qhpi8y006-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 56
🟠 accessibility 88
🟠 best-practices 87
🟠 seo 77
🔴 pwa 42

🌎 https://hiro-explorer-qhpi8y006-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 67
🟠 accessibility 89
🟠 best-practices 80
🟠 seo 77
🔴 pwa 42

🌎 https://hiro-explorer-qhpi8y006-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
⚡️ Lighthouse report

Category Score
🟠 performance 67
🟠 accessibility 89
🟠 best-practices 87
🟠 seo 76
🔴 pwa 42

@github-actions
Copy link

github-actions bot commented Jul 7, 2022 •
edited

❌ .interactive failure on https://explorer-git-prod-reference-blockstack.vercel.app/?chain=mainnet
Time to Interactive - docs

Actual Expected
6518.104999999999 <= 3000

❌ .total-blocking-time failure on https://explorer-git-prod-reference-blockstack.vercel.app/?chain=mainnet
Total Blocking Time - docs

Actual Expected
836.7250000000004 <= 200

❌ script.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
658033 <= 102400

❌ total.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
771843 <= 409600

❌ .interactive failure on https://explorer-git-prod-reference-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Time to Interactive - docs

Actual Expected
10781.847000000002 <= 3000

❌ .total-blocking-time failure on https://explorer-git-prod-reference-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Total Blocking Time - docs

Actual Expected
4160 <= 200

❌ .speed-index failure on https://explorer-git-prod-reference-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Speed Index - docs

Actual Expected
4240.748295835488 <= 3500

❌ script.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
727686 <= 102400

❌ total.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
824836 <= 409600

❌ .interactive failure on https://explorer-git-prod-reference-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Time to Interactive - docs

Actual Expected
7991.162 <= 3000

❌ .total-blocking-time failure on https://explorer-git-prod-reference-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Total Blocking Time - docs

Actual Expected
1585 <= 200

❌ script.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
688321 <= 102400

❌ total.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
797355 <= 409600

❌ .interactive failure on https://explorer-git-prod-reference-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Time to Interactive - docs

Actual Expected
7301.532 <= 3000

❌ .total-blocking-time failure on https://explorer-git-prod-reference-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Total Blocking Time - docs

Actual Expected
1768 <= 200

❌ script.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
660724 <= 102400

❌ total.size.resource-summary failure on https://explorer-git-prod-reference-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
725653 <= 409600

❌ .interactive failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/?chain=mainnet
Time to Interactive - docs

Actual Expected
6980.528 <= 3000

❌ .total-blocking-time failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/?chain=mainnet
Total Blocking Time - docs

Actual Expected
773.5000000000005 <= 200

❌ script.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
643188 <= 102400

❌ total.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
746224 <= 409600

❌ .interactive failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Time to Interactive - docs

Actual Expected
10845.957999999999 <= 3000

❌ .total-blocking-time failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Total Blocking Time - docs

Actual Expected
4605 <= 200

❌ .speed-index failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Speed Index - docs

Actual Expected
4345.533471122575 <= 3500

❌ third-party.count.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
16 <= 14

❌ script.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
698527 <= 102400

❌ total.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/txid/0xa176909e4681cf41cf8662ce51ffcf109fb2fdb2aeae6bb8425d236241debe3f?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
795924 <= 409600

❌ .interactive failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Time to Interactive - docs

Actual Expected
7062.308 <= 3000

❌ .total-blocking-time failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Total Blocking Time - docs

Actual Expected
1463 <= 200

❌ third-party.count.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
21 <= 14

❌ script.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
659167 <= 102400

❌ total.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/address/SM2MARAVW6BEJCD13YV2RHGYHQWT7TDDNMNRB1MVT?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
739947 <= 409600

❌ .interactive failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Time to Interactive - docs

Actual Expected
6983.112000000001 <= 3000

❌ .total-blocking-time failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Total Blocking Time - docs

Actual Expected
1557 <= 200

❌ script.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
644254 <= 102400

❌ total.size.resource-summary failure on https://hiro-explorer-qhpi8y006-blockstack.vercel.app/block/0xe1c163a23ce0fa8a552b5237c25bc36f3ec0612eb8a01322d9f154f09163b1a0?chain=mainnet
Keep request counts low and transfer sizes small - docs

Actual Expected
709023 <= 409600

@beguene beguene temporarily deployed to k8s-staging July 8, 2022 09:05 Inactive
This was referenced Jul 12, 2022
Closed
Closed
@beguene beguene force-pushed the fix/improve-perf branch 2 times, most recently from f5f592e to 46638ad Compare July 20, 2022 10:06
@beguene beguene temporarily deployed to k8s-staging July 20, 2022 11:21 Inactive
@beguene
fix: improve performance across many pages
a8087b0 
move most SSR api calls to client side
add e2e for the top pages
replace the v2 endpoint with a v1 /nonce fetch
add skeleton while loading data
remove some jotai code
leverage some caching

closes #586
closes #776
closes #785
closes #786
closes #601
closes #449
@beguene beguene temporarily deployed to k8s-staging July 22, 2022 12:55 Inactive
@beguene beguene marked this pull request as ready for review July 22, 2022 13:29
@beguene beguene merged commit 3c7abb3 into main Jul 25, 2022
@beguene beguene deleted the fix/improve-perf branch July 25, 2022 13:10
@blockstack-devops
Copy link

🎉 This PR is included in version 1.28.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve performance for top pages
2 participants
@beguene @blockstack-devops