feat: add tooltip to navigation icons in sandbox #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tuanphungcz is attempting to deploy a commit to the Blockstack Team on Vercel. A member of the Team first needs to authorize it. |
tuanphungcz
commented
Nov 3, 2022
src/sandbox/components/side-nav.tsx
Outdated
| @@ -5,7 +5,6 @@ import { ClarityIcon } from '@sandbox/components/clarity-icon'; | |||
| import { Tooltip } from '@components/tooltip'; | |||
| import FunctionIcon from 'mdi-react/FunctionIcon'; | |||
| import { DropIcon } from '@components/icons/drop'; | |||
| import { Routes } from '@sandbox/common/types'; | |||
tuanphungcz
commented
Nov 3, 2022
src/sandbox/components/side-nav.tsx
Outdated
| </Grid> | ||
| </Link> | ||
| <Tooltip placement="left" label={nav.label}> | ||
| <div> |
There was a problem hiding this comment.
< Tooltip /> tooltip round <Link /> doesn't render the tooltip, so I had to add the div.
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@tuanphungcz Sorry for the delay -- can you resolve the merge conflict on this branch and rebase into a single commit, then I'll go ahead and merge? Thanks! |
tuanphungcz
force-pushed
the
feat/tooltip-sandbox
branch
from
743b077
to
23bcd18
Compare
|
@leahjlou Sure, I just rebased and resolved the conflict. |
|
🎉 This PR is included in version 1.59.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #851
Solution
added a tooltip to navigation icons in the sandbox
Demo
tooltip-sandbox.online-video-cutter.com.mp4