fix: pox 4 revoke events #1829

janniks · 2024-01-16T00:33:18Z

Closes #1761

updates rosetta for signer-key
updates tests for signer-key
adds helper for using descriptor wallet for address format tests
adds timeouts to flaky tests
some assumptions I'm not 100% certain about, but tests are green 😶

github-actions · 2024-01-16T17:36:54Z

Vercel deployment URL: https://stacks-blockchain-m5sg0d104-blockstack.vercel.app 🚀

codecov · 2024-01-16T17:37:18Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (dc89bf3) 71.79% compared to head (ab363ef) 71.95%.

Files	Patch %	Lines
src/rosetta/rosetta-helpers.ts	66.66%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           nakamoto    #1829      +/-   ##
============================================
+ Coverage     71.79%   71.95%   +0.15%     
============================================
  Files            92       92              
  Lines         11907    11907              
  Branches       2624     2624              
============================================
+ Hits           8549     8568      +19     
+ Misses         3205     3186      -19     
  Partials        153      153

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

migrations/1706196613000_update-pox4-event-constraint.js

janniks · 2024-01-25T16:08:16Z

src/test-utils/test-helpers.ts

@@ -160,8 +162,10 @@ export async function standByForPoxCycle(
  do {
    await standByUntilBurnBlock(lastPoxInfo.current_burnchain_block_height! + 1, api, client);
    lastPoxInfo = await client.getPox();
-  } while (lastPoxInfo.current_cycle.id <= firstPoxInfo.current_cycle.id);
-  expect(lastPoxInfo.current_cycle.id).toBe(firstPoxInfo.next_cycle.id);


Not sure about this change. Basically current_cycle.id can be incorrect and shouldn't really be tested against. I'm thinking most tests rely on the rough behavior here and not the exact value.

* test: fix flakiness with `pox-4-btc-address-formats` tests * test: specify new bitcoin wallet name * test: fix main bitcoin wallet private key pollution in more tests

## [7.9.0-nakamoto.1](v7.8.0...v7.9.0-nakamoto.1) (2024-01-25) ### Features * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849)

blockstack-devops · 2024-01-25T22:28:50Z

🎉 This PR is included in version 7.9.0-nakamoto.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0-nakamoto.1](v7.9.0...v7.10.0-nakamoto.1) (2024-03-21) ### Features * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) ### Bug Fixes * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

blockstack-devops · 2024-03-21T16:40:33Z

🎉 This PR is included in version 7.10.0-nakamoto.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0-beta.1](v7.9.0...v7.10.0-beta.1) (2024-03-21) ### Features * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) ### Bug Fixes * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

blockstack-devops · 2024-03-21T16:48:54Z

🎉 This PR is included in version 7.10.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0](v7.9.1...v7.10.0) (2024-04-15) ### Features * add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8)) * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) * rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929) ### Bug Fixes * add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971)) * batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d)) * cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600)) * cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558)) * delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db)) * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25)) * other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64)) * pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

blockstack-devops · 2024-04-15T17:01:45Z

🎉 This PR is included in version 7.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0-beta.1](v7.9.1...v7.10.0-beta.1) (2024-04-15) ### Features * add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8)) * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) * rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929) * support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c)) ### Bug Fixes * add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971)) * batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d)) * cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600)) * cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558)) * delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db)) * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25)) * other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64)) * pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

janniks changed the base branch from develop to nakamoto January 16, 2024 00:33

janniks temporarily deployed to Preview January 16, 2024 17:34 — with GitHub Actions Inactive

zone117x linked an issue Jan 17, 2024 that may be closed by this pull request

Implement parsing for revoke-delegate-stx pox event #1761

Closed

zone117x mentioned this pull request Jan 17, 2024

chore: bump to latest stacks-node next image #1831

Closed

janniks temporarily deployed to Preview January 17, 2024 16:50 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 17, 2024 17:13 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 17, 2024 18:00 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 17, 2024 18:02 — with GitHub Actions Inactive

zone117x linked an issue Jan 22, 2024 that may be closed by this pull request

[Nakamoto] Support pox-4 changes #1735

Closed

janniks temporarily deployed to Preview January 22, 2024 17:40 — with GitHub Actions Inactive

janniks had a problem deploying to Preview January 22, 2024 22:46 — with GitHub Actions Failure

janniks force-pushed the feat/pox-4-revoke-events branch from 9e61b40 to 2acac32 Compare January 22, 2024 22:47

janniks temporarily deployed to Preview January 22, 2024 22:47 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 22, 2024 23:10 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 23, 2024 00:44 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 23, 2024 00:47 — with GitHub Actions Inactive

janniks force-pushed the feat/pox-4-revoke-events branch from 8a21c49 to f13006d Compare January 23, 2024 00:56

janniks temporarily deployed to Preview January 23, 2024 00:56 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 23, 2024 01:26 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 23, 2024 13:42 — with GitHub Actions Inactive

janniks force-pushed the feat/pox-4-revoke-events branch from 5393a7c to 4a79c5f Compare January 23, 2024 16:23

janniks temporarily deployed to Preview January 23, 2024 16:23 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 23, 2024 22:07 — with GitHub Actions Inactive

zone117x temporarily deployed to Preview January 24, 2024 10:25 — with GitHub Actions Inactive

zone117x mentioned this pull request Jan 24, 2024

merge from nakamoto #1842

Closed

janniks temporarily deployed to Preview January 24, 2024 14:30 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 24, 2024 14:34 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 24, 2024 16:55 — with GitHub Actions Inactive

janniks temporarily deployed to Preview January 25, 2024 15:43 — with GitHub Actions Inactive

janniks marked this pull request as ready for review January 25, 2024 15:44

janniks added 2 commits January 25, 2024 17:05

fix: add migration for pox-4

11ba147

chore: undo beta version of stackingclient

20db1c0

janniks force-pushed the feat/pox-4-revoke-events branch from f9d617f to 20db1c0 Compare January 25, 2024 16:05

janniks temporarily deployed to Preview January 25, 2024 16:05 — with GitHub Actions Inactive

janniks commented Jan 25, 2024

View reviewed changes

migrations/1706196613000_update-pox4-event-constraint.js Show resolved Hide resolved

janniks commented Jan 25, 2024

View reviewed changes

ci: do not require epoch2.5 tests to pass for now, too flaky

ffe0502

zone117x temporarily deployed to Preview January 25, 2024 16:54 — with GitHub Actions Inactive

test: switch order in test

554e6ee

janniks temporarily deployed to Preview January 25, 2024 21:05 — with GitHub Actions Inactive

test: fix flakiness with pox-4-btc-address-formats tests (#1849)

ab363ef

* test: fix flakiness with `pox-4-btc-address-formats` tests * test: specify new bitcoin wallet name * test: fix main bitcoin wallet private key pollution in more tests

zone117x temporarily deployed to Preview January 25, 2024 21:47 — with GitHub Actions Inactive

zone117x approved these changes Jan 25, 2024

View reviewed changes

zone117x merged commit 5e5650a into nakamoto Jan 25, 2024
29 of 30 checks passed

zone117x deleted the feat/pox-4-revoke-events branch January 25, 2024 22:23

blockstack-devops added the released on @nakamoto label Jan 25, 2024

janniks mentioned this pull request Jan 29, 2024

Implement parsing for revoke-delegate-stx pox event #1761

Closed

blockstack-devops added the released on @beta label Mar 21, 2024

blockstack-devops added the released label Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: pox 4 revoke events #1829

fix: pox 4 revoke events #1829

janniks commented Jan 16, 2024 •

edited

github-actions bot commented Jan 16, 2024 •

edited

codecov bot commented Jan 16, 2024 •

edited

janniks Jan 25, 2024

blockstack-devops commented Jan 25, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Apr 15, 2024

fix: pox 4 revoke events #1829

fix: pox 4 revoke events #1829

Conversation

janniks commented Jan 16, 2024 • edited

github-actions bot commented Jan 16, 2024 • edited

codecov bot commented Jan 16, 2024 • edited

Codecov Report

janniks Jan 25, 2024

Choose a reason for hiding this comment

blockstack-devops commented Jan 25, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Apr 15, 2024

janniks commented Jan 16, 2024 •

edited

github-actions bot commented Jan 16, 2024 •

edited

codecov bot commented Jan 16, 2024 •

edited