feat: ingest signer_bitvec #1900

zone117x · 2024-03-20T09:42:52Z

Progress towards #1893

Ingest new signer_bitvec property from /new_block event. Deserializes the Stacks consensus encoding into a base-2 string, and store in the postgres native bitvec type bit varying.

The property is added to the blocks table, but it is not included in the block data returned by various endpoints, because clients probably won't have a direct use for it.

We are anticipating to use this to generate signer performance data when the signer_bitvec data we receive has real data (right now it's still dummy data).

codecov · 2024-03-20T09:44:25Z

Codecov Report

Attention: Patch coverage is 88.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.78%. Comparing base (d2c2805) to head (94a30f4).
Report is 1 commits behind head on nakamoto.

Files	Patch %	Lines
src/event-stream/event-server.ts	60.00%	2 Missing ⚠️
src/helpers.ts	95.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           nakamoto    #1900      +/-   ##
============================================
- Coverage     72.78%   72.78%   -0.01%     
============================================
  Files            93       93              
  Lines         12254    12278      +24     
  Branches       2810     2818       +8     
============================================
+ Hits           8919     8936      +17     
- Misses         3177     3183       +6     
- Partials        158      159       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-03-20T09:45:17Z

Vercel deployment URL: https://stacks-blockchain-nl3iqjxle-blockstack.vercel.app 🚀

rafaelcr · 2024-03-20T16:10:57Z

src/helpers.ts

@@ -783,3 +783,45 @@ export function getUintEnvOrDefault(envName: string, defaultValue = 0) {
  }
  return Number(v);
 }
+
+export class BitVec {


Could this deserializer be moved to your Rust lib? Maybe in another PR?

Yeah, probably another PR if needed. I don't expect this to be a bottleneck though.

## [7.9.0-nakamoto.8](v7.9.0-nakamoto.7...v7.9.0-nakamoto.8) (2024-03-20) ### Features * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))

blockstack-devops · 2024-03-20T16:44:34Z

🎉 This PR is included in version 7.9.0-nakamoto.8 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0-nakamoto.1](v7.9.0...v7.10.0-nakamoto.1) (2024-03-21) ### Features * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) ### Bug Fixes * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

blockstack-devops · 2024-03-21T16:40:12Z

🎉 This PR is included in version 7.10.0-nakamoto.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0-beta.1](v7.9.0...v7.10.0-beta.1) (2024-03-21) ### Features * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) ### Bug Fixes * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

blockstack-devops · 2024-03-21T16:48:30Z

🎉 This PR is included in version 7.10.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0](v7.9.1...v7.10.0) (2024-04-15) ### Features * add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8)) * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) * rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929) ### Bug Fixes * add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971)) * batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d)) * cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600)) * cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558)) * delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db)) * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25)) * other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64)) * pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

blockstack-devops · 2024-04-15T17:01:21Z

🎉 This PR is included in version 7.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [7.10.0-beta.1](v7.9.1...v7.10.0-beta.1) (2024-04-15) ### Features * add nakamoto block time to v2 endpoints ([#1921](#1921)) ([ae6bbe8](ae6bbe8)) * add signer-keys from pox4 events ([#1857](#1857)) ([c17ad23](c17ad23)) * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f)) * nakamoto block timestamps ([#1886](#1886)) ([f547832](f547832)) * pox 4 revoke events and signer-key support ([#1829](#1829)) ([5e5650a](5e5650a)), closes [#1849](#1849) * pox stacker & signer cycle details ([#1873](#1873)) ([d2c2805](d2c2805)) * rosetta pox4 stacking support ([#1928](#1928)) ([2ba36f9](2ba36f9)), closes [#1929](#1929) * support multiple STX faucet source accounts ([#1946](#1946)) ([5d69c7c](5d69c7c)) ### Bug Fixes * add nakamoto testnet to openapi docs ([#1910](#1910)) ([01fb971](01fb971)) * batch drop mempool transactions ([#1920](#1920)) ([a7ee96d](a7ee96d)) * cycle signer filter ([#1916](#1916)) ([dc7d600](dc7d600)) * cycles response for empty cycle info ([#1914](#1914)) ([a7a4558](a7a4558)) * delegate-stx burn-op parsing and test fix ([#1939](#1939)) ([73ec0db](73ec0db)) * event-replay readiness for nakamoto & fix for [#1879](#1879) ([#1903](#1903)) ([1572e73](1572e73)) * log message when sql migration is performed ([#1942](#1942)) ([49a4d25](49a4d25)) * other empty result responses ([#1915](#1915)) ([3cd2c64](3cd2c64)) * pox4 stack-stx burn-op handling ([#1936](#1936)) ([9e9a464](9e9a464)) * remove signer columns from tenure-change transactions ([#1845](#1845)) ([8ec726b](8ec726b)) * sql transactional consistency bug with fetching chaintip in various areas ([#1853](#1853)) ([ada8536](ada8536))

zone117x requested a review from rafaelcr March 20, 2024 09:42

zone117x temporarily deployed to Preview March 20, 2024 09:42 — with GitHub Actions Inactive

zone117x linked an issue Mar 20, 2024 that may be closed by this pull request

[Nakamoto] Associate signer_bitvec with reward_set signers #1893

Open

zone117x temporarily deployed to Preview March 20, 2024 09:58 — with GitHub Actions Inactive

zone117x temporarily deployed to Preview March 20, 2024 10:08 — with GitHub Actions Inactive

zone117x force-pushed the feat/signer-bitvec branch from 483de06 to 9acfc9b Compare March 20, 2024 10:16

zone117x temporarily deployed to Preview March 20, 2024 10:17 — with GitHub Actions Inactive

zone117x force-pushed the feat/signer-bitvec branch from 9acfc9b to 8e03588 Compare March 20, 2024 10:38

zone117x temporarily deployed to Preview March 20, 2024 10:38 — with GitHub Actions Inactive

rafaelcr reviewed Mar 20, 2024

View reviewed changes

Base automatically changed from feat/ingest-signer-events to nakamoto March 20, 2024 16:11

rafaelcr approved these changes Mar 20, 2024

View reviewed changes

zone117x added 2 commits March 20, 2024 17:32

feat: ingest signer_bitvec

306a322

test: add bitvec tests

94a30f4

zone117x force-pushed the feat/signer-bitvec branch from 8e03588 to 94a30f4 Compare March 20, 2024 16:33

zone117x temporarily deployed to Preview March 20, 2024 16:33 — with GitHub Actions Inactive

zone117x merged commit aa1750f into nakamoto Mar 20, 2024
27 of 30 checks passed

zone117x deleted the feat/signer-bitvec branch March 20, 2024 16:38

blockstack-devops pushed a commit that referenced this pull request Mar 20, 2024

chore(release): 7.9.0-nakamoto.8 [skip ci]

7c2b3b4

## [7.9.0-nakamoto.8](v7.9.0-nakamoto.7...v7.9.0-nakamoto.8) (2024-03-20) ### Features * ingest signer_bitvec ([#1900](#1900)) ([aa1750f](aa1750f))

blockstack-devops added the released on @nakamoto label Mar 20, 2024

blockstack-devops added the released on @beta label Mar 21, 2024

blockstack-devops added the released label Apr 15, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ingest signer_bitvec #1900

feat: ingest signer_bitvec #1900

zone117x commented Mar 20, 2024

codecov bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading

rafaelcr Mar 20, 2024

zone117x Mar 20, 2024

blockstack-devops commented Mar 20, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Apr 15, 2024

feat: ingest signer_bitvec #1900

feat: ingest signer_bitvec #1900

Conversation

zone117x commented Mar 20, 2024

codecov bot commented Mar 20, 2024 • edited Loading

Codecov Report

github-actions bot commented Mar 20, 2024 • edited Loading

rafaelcr Mar 20, 2024

Choose a reason for hiding this comment

zone117x Mar 20, 2024

Choose a reason for hiding this comment

blockstack-devops commented Mar 20, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Mar 21, 2024

blockstack-devops commented Apr 15, 2024

codecov bot commented Mar 20, 2024 •

edited

Loading

github-actions bot commented Mar 20, 2024 •

edited

Loading