Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed the order of microblocks_streamed #1528

Merged

Conversation

sulemanqaiser97
Copy link
Contributor

Description

The endpoint for retrieving blocks was returning the microblocks_streamed field in reverse order. This commit changes the sorting from descending to ascending to match the expected behavior.

For details refer to issue #1524

Type of Change

  • Bug fix

Checklist

  • Unit test modified to check ascending order of microblocks_streamed
  • npm run test passes

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2023

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #1528 (70e9a79) into develop (720dc87) will increase coverage by 11.64%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           develop    #1528       +/-   ##
============================================
+ Coverage    67.13%   78.78%   +11.64%     
============================================
  Files           77       77               
  Lines        10835    10835               
  Branches      2397     2397               
============================================
+ Hits          7274     8536     +1262     
+ Misses        3337     2199     -1138     
+ Partials       224      100      -124     
Impacted Files Coverage Δ
src/datastore/pg-store.ts 93.84% <ø> (+6.52%) ⬆️
src/ec-helpers.ts 92.15% <0.00%> (+0.98%) ⬆️
src/event-stream/event-server.ts 77.56% <0.00%> (+1.35%) ⬆️
src/api/init.ts 79.54% <0.00%> (+2.27%) ⬆️
src/datastore/pg-write-store.ts 87.69% <0.00%> (+3.29%) ⬆️
src/datastore/connection-legacy.ts 60.49% <0.00%> (+4.93%) ⬆️
src/helpers.ts 70.43% <0.00%> (+6.56%) ⬆️
src/api/controllers/db-controller.ts 81.05% <0.00%> (+6.73%) ⬆️
src/datastore/helpers.ts 79.75% <0.00%> (+8.45%) ⬆️
... and 22 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 78.58%. Remained the same when pulling 70e9a79 on sulemanqaiser97:fix/microblocks_streamed-order into 720dc87 on hirosystems:develop.

@rafaelcr rafaelcr merged commit 764f64a into hirosystems:develop Jan 23, 2023
blockstack-devops pushed a commit that referenced this pull request Feb 14, 2023
## [7.1.0-beta.1](v7.0.0...v7.1.0-beta.1) (2023-02-14)

### Features

* beta release with subnets support ([06164eb](06164eb))
* support for subnets ([#1549](#1549)) ([5d7056c](5d7056c))

### Bug Fixes

* fixed the order of microblocks_streamed returned in reverse order in block endpoint ([#1528](#1528)) ([764f64a](764f64a))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.1.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

hugocaillard pushed a commit that referenced this pull request Mar 22, 2023
blockstack-devops pushed a commit that referenced this pull request Apr 18, 2023
## [7.1.0-subnets.1](v7.0.0...v7.1.0-subnets.1) (2023-04-18)

### Features

* beta release with subnets support ([06164eb](06164eb))
* support for subnets ([#1549](#1549)) ([5d7056c](5d7056c))
* support register asset event synthetic tx parsing ([#1583](#1583)) ([57d58f2](57d58f2))

### Bug Fixes

* fixed the order of microblocks_streamed returned in reverse order in block endpoint ([#1528](#1528)) ([764f64a](764f64a))
* publish `subnets` branch/channel prerelease of API ([1f7ad41](1f7ad41))
* **subnets:** use boot address for burnchain-tx signer ([#1618](#1618)) ([b1d6824](b1d6824)), closes [#1616](#1616)
@blockstack-devops
Copy link

🎉 This PR is included in version 7.1.0-subnets.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

zone117x added a commit that referenced this pull request Apr 20, 2023
* feat: beta release with subnets support

* chore(release): 7.1.0-beta.1 [skip ci]

## [7.1.0-beta.1](v7.0.0...v7.1.0-beta.1) (2023-02-14)

### Features

* beta release with subnets support ([06164eb](06164eb))
* support for subnets ([#1549](#1549)) ([5d7056c](5d7056c))

### Bug Fixes

* fixed the order of microblocks_streamed returned in reverse order in block endpoint ([#1528](#1528)) ([764f64a](764f64a))

* Merge master into beta

* chore: update l1 and l2 subnet contracts

* chore: update subnets docker compose to latest 2.1 image

* chore: enable subnet STX transfer tests

* chore: progress on fixing test for subnet to L1 FT withdrawal

* feat: support register asset event synthetic tx parsing (#1583)

* feat: support register asset event synthetic tx parsing

* test: integration tests for register-new-ft-contract and register-new-nft-contract synthetic txs

* feat: update 'register-asset-contract' event parsing

* chore: bump to latest subnet docker image (also include subnets.Dockerfile for local dev)

* chore(release): 7.1.0-beta.2 [skip ci]

## [7.1.0-beta.2](v7.1.0-beta.1...v7.1.0-beta.2) (2023-03-16)

### Features

* support register asset event synthetic tx parsing ([#1583](#1583)) ([57d58f2](57d58f2))

---------

Co-authored-by: semantic-release-bot <semantic-release-bot@martynus.net>
blockstack-devops pushed a commit that referenced this pull request Apr 20, 2023
## [7.2.0-beta.1](v7.1.7...v7.2.0-beta.1) (2023-04-20)

### Features

* stacking pool members endpoint ([#1592](#1592)) ([3cd6023](3cd6023)), closes [#465](#465)
* support for subnets ([#1549](#1549)) ([5d7056c](5d7056c))
* support for subnets ([#1625](#1625)) ([bfac932](bfac932)), closes [#1549](#1549) [#1528](#1528) [#1583](#1583) [#1583](#1583)

### Bug Fixes

* disabled BTC faucet endpoint ([#1530](#1530)) ([ce55212](ce55212))
* domain migration ([#1596](#1596)) ([2769e68](2769e68))
* fixed the order of microblocks_streamed returned in reverse order in block endpoint ([#1528](#1528)) ([764f64a](764f64a))
* log cleanup ([#1613](#1613)) ([a067e39](a067e39))
* log level issues ([#1605](#1605)) ([c3a2377](c3a2377)), closes [#1603](#1603) [#1603](#1603) [#1604](#1604) [#1604](#1604) [#1452](#1452)
* npm publish step ([#1617](#1617)) ([c9cdbb6](c9cdbb6))
* optimize queries to retrieve BNS names ([#1581](#1581)) ([1a6fde1](1a6fde1))
* use chaintip-cache-control in `/stx_supply` endpoints [#1590](#1590) ([#1594](#1594)) ([a47f153](a47f153))
* warning logger level for RPC proxy errors ([#1612](#1612)) ([2454932](2454932))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.2.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

blockstack-devops pushed a commit that referenced this pull request Jul 12, 2023
## [7.3.0](v7.2.2...v7.3.0) (2023-07-12)

### Features

* stacking pool members endpoint ([#1592](#1592)) ([3cd6023](3cd6023)), closes [#465](#465)
* support custom chain_id (e.g. for subnets) ([#1669](#1669)) ([1c6e35a](1c6e35a))
* support for subnets ([#1549](#1549)) ([5d7056c](5d7056c))
* support for subnets ([#1625](#1625)) ([bfac932](bfac932)), closes [#1549](#1549) [#1528](#1528) [#1583](#1583) [#1583](#1583)

### Bug Fixes

* add indexes to pox3_events table used for stacker lookup endpoints ([86304be](86304be))
* disabled BTC faucet endpoint ([#1530](#1530)) ([ce55212](ce55212))
* domain migration ([#1596](#1596)) ([2769e68](2769e68))
* enable requests auto logging ([#1656](#1656)) ([2015b9c](2015b9c))
* fixed the order of microblocks_streamed returned in reverse order in block endpoint ([#1528](#1528)) ([764f64a](764f64a))
* log cleanup ([#1613](#1613)) ([a067e39](a067e39))
* log level issues ([#1605](#1605)) ([c3a2377](c3a2377)), closes [#1603](#1603) [#1603](#1603) [#1604](#1604) [#1604](#1604) [#1452](#1452)
* npm publish step ([#1617](#1617)) ([c9cdbb6](c9cdbb6))
* optimize queries to retrieve BNS names ([#1581](#1581)) ([1a6fde1](1a6fde1))
* use chaintip-cache-control in `/stx_supply` endpoints [#1590](#1590) ([#1594](#1594)) ([a47f153](a47f153))
* use pox3 for `/extended/beta/stacking/...` endpoint ([872f7e6](872f7e6))
* warning logger level for RPC proxy errors ([#1612](#1612)) ([2454932](2454932))
@blockstack-devops
Copy link

🎉 This PR is included in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants