Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mempool nonces to address endpoint JSON response #1633

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

csgui
Copy link
Collaborator

@csgui csgui commented Apr 26, 2023

This PR adds mempool nonces to the response of extended/v1/address/:stx_address/nonces endpoint.

Issue 1342.

@github-actions
Copy link

github-actions bot commented Apr 26, 2023

@github-actions github-actions bot temporarily deployed to pull request April 26, 2023 15:24 Inactive
@github-actions github-actions bot temporarily deployed to commit April 26, 2023 15:24 Inactive
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #1633 (0debfe2) into develop (bfac932) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1633      +/-   ##
===========================================
+ Coverage    77.83%   77.84%   +0.01%     
===========================================
  Files           78       78              
  Lines        11301    11302       +1     
  Branches      2503     2503              
===========================================
+ Hits          8796     8798       +2     
+ Misses        2391     2390       -1     
  Partials       114      114              
Impacted Files Coverage Δ
src/api/routes/address.ts 84.72% <ø> (ø)
src/datastore/pg-store.ts 94.10% <100.00%> (+<0.01%) ⬆️

... and 1 file with indirect coverage changes

@csgui csgui marked this pull request as draft April 26, 2023 16:35
@github-actions github-actions bot temporarily deployed to pull request April 26, 2023 17:58 Inactive
@github-actions github-actions bot temporarily deployed to commit April 26, 2023 17:58 Inactive
@csgui csgui marked this pull request as ready for review April 26, 2023 18:00
@github-actions github-actions bot temporarily deployed to commit April 26, 2023 18:02 Inactive
@github-actions github-actions bot temporarily deployed to pull request April 26, 2023 18:02 Inactive
@csgui csgui requested review from rafaelcr and zone117x and removed request for rafaelcr April 26, 2023 18:12
@coveralls
Copy link
Collaborator

Coverage Status

Coverage: 77.527% (+1.9%) from 75.6% when pulling 0debfe2 on fix/mempool-nonces into bfac932 on develop.

Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@zone117x zone117x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @csgui!

@csgui csgui merged commit a6c8f16 into develop Apr 28, 2023
@csgui csgui deleted the fix/mempool-nonces branch April 28, 2023 16:38
@blockstack-devops
Copy link

🎉 This PR is included in version 7.2.0-beta.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blockstack-devops
Copy link

🎉 This PR is included in version 7.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants