-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support message signing with Ledger hardware wallets #2433
Comments
@landitus Will this require significant design changes to support, or is the flow similar to one we've already designed for Ledger? |
Seems it will be straightforward as we can use the Tx signing flow as a blueprint. It's basically the same UI. We could go straight to implementation without mocks if needed, but I would still take some time to add this new flow to the wallet flow maps and check if something tricky appears. |
I've mocked the happy path, and indeed we are going to use the same UX/UI as the TX signing with ledger.
Links CleanShot.2022-06-24.at.15.21.07.mp4 |
@markmhx Note that the Ledger only supports text-based message signing. We will need to work with Zondax to implement the structured data signing feature. |
The message signing feature, just released, hasn't been implemented for Ledger yet.
A message signing flow should be created, following steps similar to transaction signing
The text was updated successfully, but these errors were encountered: