Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support message signing with Ledger hardware wallets #2433

Closed
kyranjamie opened this issue May 18, 2022 · 4 comments · Fixed by #2583
Closed

Support message signing with Ledger hardware wallets #2433

kyranjamie opened this issue May 18, 2022 · 4 comments · Fixed by #2583

Comments

@kyranjamie
Copy link
Collaborator

kyranjamie commented May 18, 2022

The message signing feature, just released, hasn't been implemented for Ledger yet.

A message signing flow should be created, following steps similar to transaction signing

@markmhendrickson
Copy link
Collaborator

@landitus Will this require significant design changes to support, or is the flow similar to one we've already designed for Ledger?

@landitus
Copy link

landitus commented Jun 23, 2022

Seems it will be straightforward as we can use the Tx signing flow as a blueprint. It's basically the same UI.

We could go straight to implementation without mocks if needed, but I would still take some time to add this new flow to the wallet flow maps and check if something tricky appears.

@landitus
Copy link

landitus commented Jun 24, 2022

I've mocked the happy path, and indeed we are going to use the same UX/UI as the TX signing with ledger.

  • I assumed we need a confirmation screen where the user will confirm on Ledger (just as the TX signing)
  • There are some CTA and Heading copy updates to adapt it to Ledger and that's mostly it!

Links

CleanShot.2022-06-24.at.15.21.07.mp4

Image

@kyranjamie
Copy link
Collaborator Author

@markmhx Note that the Ledger only supports text-based message signing. We will need to work with Zondax to implement the structured data signing feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants