fix: check if spending condition has too many sigs

hirosystems · Sep 2, 2021 · 6ad03fd · 6ad03fd
1 parent 8ae3f34
commit 6ad03fd
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/packages/transactions/src/signer.ts b/packages/transactions/src/signer.ts
@@ -24,6 +24,11 @@ export class TransactionSigner {
     // auth fields and reconstruct sigHash
     let spendingCondition = transaction.auth.spendingCondition;
     if (spendingCondition && !isSingleSig(spendingCondition)) {
+
+      if (spendingCondition.fields.length >= spendingCondition.signaturesRequired) {
+        throw new Error('SpendingCondition has more signatures than are expected');
+      }
+
       spendingCondition.fields.forEach(field => {
         if (field.contents.type === StacksMessageType.MessageSignature) {
           if (!transaction.auth.authType) {