-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect prefix for message signing #1328
Projects
Comments
kyranjamie
added a commit
that referenced
this issue
Jul 26, 2022
kyranjamie
added a commit
that referenced
this issue
Jul 26, 2022
kyranjamie
added a commit
that referenced
this issue
Aug 18, 2022
kyranjamie
added a commit
that referenced
this issue
Aug 18, 2022
janniks
pushed a commit
that referenced
this issue
Sep 14, 2022
Do we have a SIP for that? |
I don't believe there is a SIP for general message signing (with prefix for safety) yet. Only SIP-018 with a separate prefix (which might also cause problems with ledger). There are also more comments and information in the PR: #1329 |
janniks
added a commit
that referenced
this issue
Sep 29, 2022
janniks
added a commit
that referenced
this issue
Sep 29, 2022
BREAKING CHANGE: The message signing prefix was changed from `Stacks Message Signing` to `Stacks Signed Message`.
janniks
added a commit
that referenced
this issue
Sep 29, 2022
BREAKING CHANGE: The message signing prefix was changed from `Stacks Message Signing` to `Stacks Signed Message`.
janniks
added a commit
that referenced
this issue
Sep 29, 2022
BREAKING CHANGE: The message signing prefix was changed from `Stacks Message Signing` to `Stacks Signed Message`.
janniks
added a commit
that referenced
this issue
Sep 29, 2022
BREAKING CHANGE: The message signing prefix was changed from `Stacks Message Signing` to `Stacks Signed Message`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We use the wrong phrasing for the message signing prefix:
stacks.js/packages/encryption/src/messageSignature.ts
Lines 5 to 7 in 5ac9385
Following the Ethereum format, already followed on the Ledger app, the message should be Stacks Signed Message, not Stacks Message Signing.
This is a change of length, too, so if I'm not mistaken about how the prefixing works, should be:
"Stacks Signed Message:\n".length.toString(16) // 17
Useful info on prefix here https://blog.ricmoo.com/verifying-messages-in-solidity-50a94f82b2ca
The text was updated successfully, but these errors were encountered: