Incorrect prefix for message signing

[kyranjamie]

We use the wrong phrasing for the message signing prefix:

stacks.js/packages/encryption/src/messageSignature.ts

Lines 5 to 7 in 5ac9385

	// 'Stacks Message Signing:\n'.length // = 24
	// 'Stacks Message Signing:\n'.length.toString(16) // = 18
	const chainPrefix = '\x18Stacks Message Signing:\n';

Following the Ethereum format, already followed on the Ledger app, the message should be Stacks Signed Message, not Stacks Message Signing.

This is a change of length, too, so if I'm not mistaken about how the prefixing works, should be:

\x17Stacks Signed Message:\n

"Stacks Signed Message:\n".length.toString(16) // 17

Useful info on prefix here https://blog.ricmoo.com/verifying-messages-in-solidity-50a94f82b2ca

[friedger]

Do we have a SIP for that?

[janniks]

I don't believe there is a SIP for general message signing (with prefix for safety) yet. Only SIP-018 with a separate prefix (which might also cause problems with ledger).

There are also more comments and information in the PR: #1329