Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to new network object #1623

Merged
merged 2 commits into from Mar 7, 2024
Merged

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Feb 5, 2024

Part of #1622

This PR:

  • adds the new "static" network (keeping the network package, most users won't need to import, because they can use string literals)
  • adds new .api options to allow separately from network defining a .url and .fetch to use
  • moves "fetch" functions from tx/builders.ts to tx/fetch.ts

Split into multiple PRs for easier reviewing

next
    ↑
feat/next-cleanup-common-files #1622
    ↑
feat/next-add-new-network this PR 🟢
    ↑
feat/next-add-api-package #1624
    ↑
feat/next-update-api-stacking #1625
    ↑
feat/next-update-cli #1626

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ❌ Failed (Inspect) Mar 7, 2024 3:30pm

@janniks janniks changed the title Feat/next add new network feat: add new network Feb 5, 2024
@janniks janniks changed the title feat: add new network [2] feat: add new network Feb 5, 2024
Copy link
Contributor

@MicaiahReid MicaiahReid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had one comment, but there were a few occurrences of it. Great work!

packages/transactions/src/fetch.ts Show resolved Hide resolved
@MicaiahReid MicaiahReid self-requested a review February 7, 2024 16:00
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Base automatically changed from feat/next-cleanup-common-files to next March 7, 2024 15:27
@janniks janniks changed the title [2] feat: add new network feat!: update to new network object Mar 7, 2024
# Conflicts:
#	packages/common/tests/fetch.test.ts
#	packages/common/tests/fetchMiddleware.test.ts
#	packages/network/src/network.ts
@janniks janniks merged commit a2171d4 into next Mar 7, 2024
7 of 9 checks passed
@janniks janniks deleted the feat/next-add-new-network branch March 7, 2024 15:31
janniks added a commit that referenced this pull request Mar 8, 2024
* feat: split network into object and api opts

* fix: update imports

---------

Co-authored-by: janniks <janniks@users.noreply.github.com>
janniks added a commit that referenced this pull request Mar 12, 2024
* feat: split network into object and api opts

* fix: update imports

---------

Co-authored-by: janniks <janniks@users.noreply.github.com>
@janniks janniks restored the feat/next-add-new-network branch March 12, 2024 01:36
@janniks janniks deleted the feat/next-add-new-network branch March 12, 2024 01:41
janniks added a commit that referenced this pull request Mar 12, 2024
* feat: split network into object and api opts

* fix: update imports

---------

Co-authored-by: janniks <janniks@users.noreply.github.com>
janniks added a commit that referenced this pull request Mar 18, 2024
* feat: split network into object and api opts

* fix: update imports

---------

Co-authored-by: janniks <janniks@users.noreply.github.com>
janniks added a commit that referenced this pull request Mar 22, 2024
* feat: split network into object and api opts

* fix: update imports

---------

Co-authored-by: janniks <janniks@users.noreply.github.com>
janniks added a commit that referenced this pull request Apr 24, 2024
* feat: split network into object and api opts

* fix: update imports

---------

Co-authored-by: janniks <janniks@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants