Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5] feat: update cli #1626

Merged
merged 5 commits into from
Mar 7, 2024
Merged

[5] feat: update cli #1626

merged 5 commits into from
Mar 7, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Feb 5, 2024

Part of #1622

This PR:

  • adapted remaining packages to new style
  • fixes tests

Split into multiple PRs for easier reviewing

next
    ↑
feat/next-cleanup-common-files #1622
    ↑
feat/next-add-new-network #1623
    ↑
feat/next-add-api-package #1624
    ↑
feat/next-update-api-stacking #1625
    ↑
feat/next-update-cli this PR 🟢

Copy link

vercel bot commented Feb 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ❌ Failed (Inspect) Mar 7, 2024 3:59pm

} else {
throw new Error(
'Invalid zonefile lookup response: did not contain `address`' + ' or `zonefile` field'
);
}
});
}

export function getNameInfo(
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function was moved here, only the api param adjusted

* @param {transaction} - StacksTransaction object to be estimated
* @return {number} Estimated transaction byte length
*/
export function estimateTransactionByteLength(transaction: StacksTransaction): number {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function moved

@janniks janniks force-pushed the feat/next-update-api-stacking branch from 6695b0f to e3e5761 Compare March 7, 2024 15:53
Base automatically changed from feat/next-update-api-stacking to next March 7, 2024 15:54
@janniks janniks merged commit 5781b6a into next Mar 7, 2024
6 of 8 checks passed
@janniks janniks deleted the feat/next-update-cli branch March 7, 2024 15:58
@janniks janniks restored the feat/next-update-cli branch March 12, 2024 01:36
@janniks janniks deleted the feat/next-update-cli branch March 12, 2024 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants