-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload token images to gcs #204
Conversation
Vercel deployment URL: https://token-metadata-ocm7b5jrh-blockstack.vercel.app 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it would be helpful to be able to lazy process images on (first) request. But that's going to involve a bigger change, maybe not worth it unless this approach runs into problems.
LGTM!
## [0.7.0-beta.1](v0.6.3...v0.7.0-beta.1) (2024-05-07) ### Features * add admin rpc to reprocess token image cache ([#205](#205)) ([2fdcb33](2fdcb33)) * update ts client with image thumbnails ([#206](#206)) ([c24cb56](c24cb56)) * upload token images to gcs ([#204](#204)) ([1cec219](1cec219)) ### Bug Fixes * get gcs auth token dynamically for image cache ([#210](#210)) ([8434b22](8434b22))
🎉 This PR is included in version 0.7.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [0.7.0](v0.6.3...v0.7.0) (2024-05-13) ### Features * add admin rpc to reprocess token image cache ([#205](#205)) ([2fdcb33](2fdcb33)) * update ts client with image thumbnails ([#206](#206)) ([c24cb56](c24cb56)) * upload token images to gcs ([#204](#204)) ([1cec219](1cec219)) ### Bug Fixes * get access token properly ([a6b98c5](a6b98c5)) * get gcs auth token dynamically for image cache ([#210](#210)) ([8434b22](8434b22)) * image cache agent arg types ([5826628](5826628)) * improve image cache error handling ([#214](#214)) ([115a745](115a745)) * reuse gcs token and validate image cache script errors ([#213](#213)) ([5e1af5c](5e1af5c))
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
cached_thumbnail_image
values to token responses so wallets or explorers may use full size or reduced size when neededRelated to #201
TODO in future PRs: Admin RPC to recalculate image of any token, update client library