-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
http2-client doesn't work in Node 12 #30
Comments
Could be related to Mermade/oas-kit#244 - if so, the regression was introduced in Node 12.17.0, and though a similar regression was fixed in the Node 14.x line, it hasn't yet been backported to 12.x |
@MikeRalphson spot on, thanks! I can confirm the tests pass fine in Node 12.16, but just not 12.17+. Eugh. Is there a Node bug somewhere documenting the underlying issue? |
I don't think anyone's tracked down the 'bad' commit or its revert yet. It would probably take some bisecting. |
Related: nodejs/node#34859 |
As far as I can tell, this project doesn't work at all in node 12.
I'm testing with Node 12.18.3 (the current node LTS release), and all HTTP/2 requests are never successfully sent to the server.
Easy to reproduce:
npm test
for this project fails, with every http2 test timing out.Any ideas why? Happy to help get this fixed, but pointers in the right direction would be very useful!
The text was updated successfully, but these errors were encountered: