Skip to content
This repository has been archived by the owner on Aug 4, 2020. It is now read-only.

String formatting not working properly. #16

Closed
krngrvr09 opened this issue Apr 9, 2015 · 2 comments
Closed

String formatting not working properly. #16

krngrvr09 opened this issue Apr 9, 2015 · 2 comments

Comments

@krngrvr09
Copy link

rsz_error1 1

ERROR %(filename)s: Not enough tests (%(actual_count)d vs %(needed_count)d) for %(rule)s

One possible solution is to replace .format(problem) with %problem. So that

logging.error("%(filename)s: Not enough tests (%(actual_count)d vs %(needed_count)d) for %(exclusion)s".format(problem))

becomes

logging.error("%(filename)s: Not enough tests (%(actual_count)d vs %(needed_count)d) for %(exclusion)s"%problem)

rsz_1corrected

@krngrvr09
Copy link
Author

A little tweak in the implementation of the case where no rule/exclusion applies to a test url, is required. I could send a PR if somebody can confirm that they are also facing the same issue on their machine.

I have tested this on python 2.7.5+ and also on 3.3.2+

@hiviah
Copy link
Owner

hiviah commented Apr 13, 2015

Fixed and pushed to master. Thanks.

@hiviah hiviah closed this as completed Apr 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants