Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-5219: Add new endpoint for returning the path to download result #505

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented Apr 5, 2024

This PR builds on #471 and should be merged after that

This PR will

  • Add a new endpoint to return the path and some metadata to the web app. We want this so that kotlin can form a download URL which it can pass to the front end for retrieving the the data in a way that means we can use the native browser download progress bar. See the epic ticket for more context

@r-ash r-ash changed the base branch from master to relative-path April 5, 2024 14:19
@r-ash r-ash changed the base branch from relative-path to master April 5, 2024 14:50
@r-ash r-ash marked this pull request as ready for review April 5, 2024 14:50
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.46%. Comparing base (7e3ef21) to head (1cb8aaa).
Report is 6 commits behind head on master.

❗ Current head 1cb8aaa differs from pull request most recent head 5fbf9d5. Consider uploading reports for the commit 5fbf9d5 to get more accurate results

Files Patch % Lines
R/endpoints.R 96.77% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #505      +/-   ##
==========================================
- Coverage   98.49%   98.46%   -0.03%     
==========================================
  Files          29       29              
  Lines        2389     2414      +25     
==========================================
+ Hits         2353     2377      +24     
- Misses         36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants