Return calibrate result path relative to the results directory #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #471 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 29 29
Lines 2389 2391 +2
=======================================
+ Hits 2353 2355 +2
Misses 36 36 ☔ View full report in Codecov by Sentry. |
richfitz
suggested changes
Apr 5, 2024
R/endpoints.R
Outdated
| @@ -253,8 +253,10 @@ calibrate_result_path <- function(queue) { | |||
| function(id) { | |||
| verify_result_available(queue, id) | |||
| result <- queue$result(id) | |||
| relative_path <- sub(paste0(queue$results_dir, .Platform$file.sep), "", | |||
There was a problem hiding this comment.
strongly suggest you use fs::path_rel for this
richfitz
approved these changes
Apr 5, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should hopefully, along with hivtools/hint-deploy#76 , simplify some of the test setup in hint, and make it less fragile - we don't have to rely on the results volume being mounted in the same point in hint and hintr anymore