Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate tests from implementations #137

Open
GoogleCodeExporter opened this issue Jun 24, 2015 · 0 comments
Open

Separate tests from implementations #137

GoogleCodeExporter opened this issue Jun 24, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

There are several classes which define overloaded constructors intended to 
implement test problems. Having tests mixed in with the implementation pollutes 
the public API and the documentation. The following classes have tests written 
in this manner:

HMWSoln
MargulesVPSSTP
MixedSolventElectrolyte
PhaseCombo_Interaction
RedlichKisterVPSSTP
RedlichKwongMFTP

These constructors should be removed and any useful test code they contain 
incorporated into new or existing tests.

Original issue reported on code.google.com by yarmond on 8 Jan 2013 at 7:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant