Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for 'N' bases #6

Closed
brendanofallon opened this issue Dec 6, 2019 · 1 comment · Fixed by #7
Closed

Support for 'N' bases #6

brendanofallon opened this issue Dec 6, 2019 · 1 comment · Fixed by #7
Assignees
Labels
enhancement New feature or request

Comments

@brendanofallon
Copy link

I'm seeing an error that looks like it involves 'N' bases (see stack trace below). Not sure if the Ns are in the ref genome (we're using b37) or the BAM file, but either way this is a showstopper since we can't guarantee that either will never have a N.

Here's the stack trace:

Traceback (most recent call last):
  File "/opt/clair/clair/../clair.py", line 93, in <module>
    main()
  File "/opt/clair/clair/../clair.py", line 87, in main
    submodule.main()
  File "/opt/clair/dataPrepScripts/ExtractVariantCandidates.py", line 450, in main
    make_candidates(args)
  File "/opt/clair/dataPrepScripts/ExtractVariantCandidates.py", line 290, in make_candidates
    base = BASE2ACGT[SEQ[query_position]]
KeyError: 'N'

Really awesome work otherwise! I think your approach has a lot of advantages over the DeepVariant method (which seems a lot just like an improved VQSR), I'm pretty excited about Clair in general!

@aquaskyline aquaskyline added the enhancement New feature or request label Dec 7, 2019
@chaklim chaklim closed this as completed in #7 Dec 9, 2019
@chaklim
Copy link
Collaborator

chaklim commented Dec 9, 2019

Right now treated 'N' bases as 'A'
and going to create an option to handle those IUPAC bases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants