Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Crash on leaving sketch after converting to mesh #427

Closed
raindropsfromsky opened this issue Dec 4, 2023 · 11 comments
Closed

[BUG] Crash on leaving sketch after converting to mesh #427

raindropsfromsky opened this issue Dec 4, 2023 · 11 comments
Labels
bug Something isn't working

Comments

@raindropsfromsky
Copy link

Contact Details

raindrops.fromsky@gmail.com

Description

Blender 4.1 crashes when we (a) convert a sketch to mesh and then (b) leave sketch.
(just conversion to mesh or just leaving sketch does not crash Blender.)

This happens regardless of the fact whether we are converting a freshly made sketch or a previously created sketch (by editing it).

If we exit the sketch WITHOUT converting to mesh, Blender does NOT crash.

Addon Version

0.27.3

Blender Version

4.1 (actually, BforArtists 4.0.1)

What platform are you running on?

Windows

@raindropsfromsky raindropsfromsky added the bug Something isn't working label Dec 4, 2023
@hlorus
Copy link
Owner

hlorus commented Dec 4, 2023

Could you share the content of the console after the crash?
https://hlorus.github.io/CAD_Sketcher/advanced/#console-output

You'll have to start blender from the console in order to see the console after the crash...

@raindropsfromsky
Copy link
Author

raindropsfromsky commented Dec 4, 2023

I toggled console with Windows > Toggle system console command.

image

Then I added a sketch with a rectangle and a circle, and left sketch without converting them into mesh.
But the console command did not register any activities at all.

Then I edited the sketch, and converted the sketch to mesh.
Again, no change in the log.

As soon as I leave the sketch, BforArtists crashes along with the console.
So I do not see anything captured in it.

After the crash, I found this file:
C:\Users<userName>\AppData\Local\Temp\CAD_Sketcher-main-Nagesh.log

(unlike the help description, the file name contains "-main-Nagesh" for some reason.)
There is no other log file with "CAD_sketcher" in its name anywhere on my laptop.
(I checked with Everywhere, which indexes all files.)

But the log file does not have any content at all. (It has 0 bytes size).


Finally, I found that I have to save the file first:
So I saved the file first, and then repeated the experiment.
This time it produced a crash report at-
C:\Users<UserName>\AppData\Local\Temp<FileName>.crash.txt

This is attached.
TestingForCrash.crash.txt

@hlorus
Copy link
Owner

hlorus commented Dec 4, 2023

Die you try the addon with vanilla blender?

To see the console after the crash you can start blender from a console. You should find it by tipping "cmd" in the windows search. From the console you should be enough to just enter "blender".

@raindropsfromsky
Copy link
Author

raindropsfromsky commented Dec 4, 2023

Yes, Blender 4.1 also crashes in an identical manner.
I launched Blender using Command Prompt.

After Blender crashed, the Command Prompt shows the following text:
(this is the entire text of the session, including installation of the addon, etc.)

C:\Program Files\Util\Blender 4.1 alpha>blender
reloading addon: CAD_Sketcher-main 1701697836.3563676 1701698062.2417014 'C:\Users\naray\AppData\Roaming\Blender Foundation\Blender\4.1\scripts\addons\CAD_Sketcher-main\init.py'
Modules Installed () from 'D:\Downloads\CAD_Skecther_0.27.3.zip' into 'C:\Users\naray\AppData\Roaming\Blender Foundation\Blender\4.1\scripts\addons'
reloading addon: CAD_Sketcher-main 1701698062.2417014 1701698089.0244324 'C:\Users\naray\AppData\Roaming\Blender Foundation\Blender\4.1\scripts\addons\CAD_Sketcher-main\init.py'
Modules Installed () from 'D:\Downloads\CAD_Skecther_0.27.3.zip' into 'C:\Users\naray\AppData\Roaming\Blender Foundation\Blender\4.1\scripts\addons'
CAD_Sketcher-main:{INFO}: Logging into: C:\Users\naray\AppData\Local\Temp\CAD_Sketcher-main-Nagesh.log
Error : EXCEPTION_ACCESS_VIOLATION
Address : 0x00007FF6128F5524
Module : blender.exe
Thread : 000018bc
Writing: C:\Users\naray\AppData\Local\Temp\blender.crash.txt

The crash log is attached:
blender.crash.txt

@hlorus
Copy link
Owner

hlorus commented Dec 4, 2023

Ahh i'm afraid we cannot take reports into account that apply to alpha versions. If this also happens with stable versions or when 4.1 gets into beta we can have another look.

@raindropsfromsky
Copy link
Author

OK. Thanks!

I tried this with Blender 4.0.2 RC and it does not crash.

Blender 4.1 is scheduled to enter the beta stage on 24th Jan 2024.
AFAICT, it won't be possible to raise this as a bug for Blender 4.1, right?

@hlorus
Copy link
Owner

hlorus commented Dec 4, 2023

AFAICT, it won't be possible to raise this as a bug for Blender 4.1, right?

How do you mean, report it to the blender Foundation?

@raindropsfromsky
Copy link
Author

raindropsfromsky commented Dec 5, 2023

Well, when an addon works with Blender 4.0 but not with 4.1, there are two possible reasons:

  1. The code of 4.1 is not backward compatible with 4.0 (so far as a given addon is concerned)
  2. Code in 4.1 is broken unintentionally (regression issue).

In the first case, the addon developers have to know how the code is going to change, so that they can make the addon compatible with the new version. IINW Blender developer forum provides this information in advance to the addon developers, so that they can modify their addons concurrently.

In the second case, the user should be redirected to raise the bug in Blender's GitHub.

As a user, I don't know which case applies here.
So if you let me know, I can close the bug here, and raise it in the Blender's GitHub.

The final intent is to give an early feedback to the right group, so that the correction can be applied at the earliest.

@hlorus
Copy link
Owner

hlorus commented Dec 5, 2023

It's likely the second scenario as braking changes are usually made in major releases. Reporting the bug upstream makes sense however this usually requires a simplified setup as blender developers probably don't have the time to install addons...

@hlorus
Copy link
Owner

hlorus commented Dec 5, 2023

Good news, they fixed it already: blender/blender@ce81bdc

@hlorus hlorus closed this as completed Dec 5, 2023
@raindropsfromsky
Copy link
Author

Great!
I use development version of bforartists, so this change will hopefully appear in next week's release!

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants