Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The containers in comm_container.py should implement __contains__ #7

Open
cash opened this issue Apr 1, 2020 · 0 comments
Open

The containers in comm_container.py should implement __contains__ #7

cash opened this issue Apr 1, 2020 · 0 comments

Comments

@cash
Copy link
Member

cash commented Apr 1, 2020

If they don't, getitem is called twice. When using the fetch wrapper one, it ends up calling the remote service twice per request. This is because of the way CommunicationContainerFetchHandler is implemented where it first tests if the item is in the mapping and then retrieves it. Another option is to change this handler's implementation to try to access and handle the error if it is not there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant