Middle click on tray icon

[libbkmz]

In README i see:
To exit the application middle-click on the tray icon
But in code i see another version:

    if ( reason == QSystemTrayIcon::MiddleClick ) {
        showMenu();
    } else if ( reason == QSystemTrayIcon::Trigger || reason == QSystemTrayIcon::DoubleClick ) {
        toggleVisible();
    }

Who to belive =)

[hluk]

Yes, I've changed that but forgot to change documentation. I'm not sure what to map middle click to. Exiting application is probably not very common action with this type of application (you can right click and select "exit" anyway).

Maybe I can just let user choose the middle-click action. Any ideas?

[scottkosty]

I agree that exiting is not common for this type of application so I personally don't think it is worth an option. If you do decide to add this as an option, it might be worth generalizing a bit:

You could have "Exit CopyQ" as en entry on the shortcuts tab of preferences and as discussed in #70, you could have button - shortcuts. If you want to extend this further, you could even have shortcuts that are triggered when right-clicking or middle-clicking on the tray icon and these could be assigned to actions. Right now, left-click and right-click on the icon do the same thing for me.

However, as I said, I would personally just close this issue and not have a middle-click exit on the tray icon.

[hluk]

Yeah, let's close this and move it to #70.

I feel like I should get rid of the tray altogether -- at least under X11 -- since in Qt 5 it doesn't work with some window managers and Unity doesn't use the standard tray.

[scottkosty]

No tray icon sounds good. It's funny that I hadn't thought about that before. I just assumed that a tray icon was necessary but now that I think about it I agree. In this case I guess if the user runs CopyQ while it's already running, that should show preferences or something similar (so that there is a way for the user to access CopyQ if (s)he forgets the shortcut or did not set one) instead of the current behavior of not doing anything?

[hluk]

I've created a task for this: #76