Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A strange issue to make copyQ crash #9

Closed
witwall opened this issue Feb 19, 2013 · 14 comments
Closed

A strange issue to make copyQ crash #9

witwall opened this issue Feb 19, 2013 · 14 comments
Labels

Comments

@witwall
Copy link

witwall commented Feb 19, 2013

when copy the text of about dialog, the copyQ crash, I tried twice, the same result.

and when restart copyQ, the clipboard has nothing.

copyQ3

@hluk
Copy link
Owner

hluk commented Feb 19, 2013

Everything works on my Linux machine. Problem seems to be QtWebKit library on Windows. You can disable "Web Items" in preferences History tab -- that should fix it temporarily.

@witwall
Copy link
Author

witwall commented Feb 20, 2013

it ocurrs only when try to copy the content of about dialog, if copy from other window, no this kind issue.

@hluk
Copy link
Owner

hluk commented Feb 20, 2013

So disabling "Web Items" doesn't help?

It crashes for me with this plugin on Windows but not always -- it seems to depend on content of the copied HTML content (usually if I copy whole HTML page from web browser).

@witwall
Copy link
Author

witwall commented Feb 20, 2013

does not help. of course, we seldom copy the content from about dialog of copyQ

@hluk
Copy link
Owner

hluk commented Feb 20, 2013

I can see what is wrong now. You can copy everything except the SVG logo. That's because I've bundled the binary for Windows with incorrect version of a library in "imageformats" directory. Also there should be probably libraries for other image formats so images can show up in items.

@hluk
Copy link
Owner

hluk commented Feb 20, 2013

This seems to be unrelated to content of "imageformats" directory. It's either problem with MinGW or Qt.

Anyway I cannot do anything about this right now -- I can wait for next version of Qt or MinGW but it's quiet possible it won't be fixed.

It would be really helpful if someone can try to compile it on Windows with different compiler.

@hluk
Copy link
Owner

hluk commented Feb 22, 2013

Binary for version 1.7.2 is compiled with different compiler and libraries. Copying the about dialog content seems to be fixed. Please verify. Also -- if possible -- verify if you can copy any HTML content and images. Thanks.

@witwall
Copy link
Author

witwall commented Feb 25, 2013

fixed,but I tried copy image from google home page, https://www.google.com/, did not work,
copyQ4

@hluk
Copy link
Owner

hluk commented Feb 25, 2013

Seems like imageformats directory still contain incorrect versions of plugins or some libs are missing.

Also libs from http://www.microsoft.com/en-us/download/details.aspx?id=5555 can be missing on some PCs (supposedly /MT linker flag needs to be specified when building the app).

Damn, I need to find a way to test it on development machine so it doesn't look for libraries on other places other than the installed folder.

@witwall
Copy link
Author

witwall commented Feb 25, 2013

I tried to compile the last version(git pull) under windows with Qt5 and MinGW, but got the following error,

In file included from ../../CopyQ/qxt/qxtglobalshortcut.cpp:32:0:
../../CopyQ/qxt/qxtglobalshortcut_p.h:56:12: error: 'EventFilter' in 'class QAbstractEventDispatcher' does not name a type
../../CopyQ/qxt/qxtglobalshortcut.cpp:39:1: error: 'EventFilter' in 'class QAbstractEventDispatcher' does not name a type
../../CopyQ/qxt/qxtglobalshortcut.cpp: In constructor 'QxtGlobalShortcutPrivate::QxtGlobalShortcutPrivate()':
../../CopyQ/qxt/qxtglobalshortcut.cpp:47:9: error: 'prevEventFilter' was not declared in this scope
../../CopyQ/qxt/qxtglobalshortcut.cpp:47:65: error: 'class QAbstractEventDispatcher' has no member named 'setEventFilter'
../../CopyQ/qxt/qxtglobalshortcut.cpp: In destructor 'virtual QxtGlobalShortcutPrivate::~QxtGlobalShortcutPrivate()':
../../CopyQ/qxt/qxtglobalshortcut.cpp:57:17: error: 'class QAbstractEventDispatcher' has no member named 'setEventFilter'
../../CopyQ/qxt/qxtglobalshortcut.cpp:57:32: error: 'prevEventFilter' was not declared in this scope

after some research, I noticed
The API for native event filters in Qt5 has been improved, the brittle event filter chaining is no longer exposed.
http://qt-project.org/wiki/BPS_Events_and_Qt

@hluk
Copy link
Owner

hluk commented Feb 25, 2013

Yes, global shortcuts in libqxt (http://dev.libqxt.org/libqxt/wiki/Home) doesn't support Qt 5. But it should be disabled automatically if building with cmake and qmake.

I would really like to see Qt 5 support in libqxt otherwise I'll have to use other library for system-wide shortcuts (with support for more platforms and Qt 4 and 5).

Well, maybe it's not that difficult to fix but I've tried -- unsuccessfully -- to quick-fix it before.

@hluk
Copy link
Owner

hluk commented Feb 25, 2013

Oh, wow -- something is just happening in libqxt with Qt 5 support: http://dev.libqxt.org/libqxt/pull-request/3/porting-qxt-to-qt5-step1/diff -- nice :).

@hluk
Copy link
Owner

hluk commented Feb 25, 2013

Ok, now we have global shortcuts with Qt 5 :) (in master branch). I just needed to implement the part for Linux/X11.

@hluk
Copy link
Owner

hluk commented Apr 3, 2014

Lot of things have changed. Is this still an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants