Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material Composer extraction #163

Merged
merged 24 commits into from
Aug 22, 2022
Merged

Material Composer extraction #163

merged 24 commits into from
Aug 22, 2022

Conversation

hmans
Copy link
Owner

@hmans hmans commented Aug 21, 2022

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code

Vanilla Package:

  • Set up new package
  • Move (and rename) VFXMaterial into this package
  • Also (some/most of) the modules and units
  • Clean up the modules and units. Do all of them need to be in this package?

R3F Package:

  • Set up new package
  • Move JSX glue into this package

Cleanup:

  • Make vfx-composer depend on these
  • Remove the dead code from vfx-composer
  • Check the dependencies. Most should probably just be peerDependencies.

@changeset-bot
Copy link

changeset-bot bot commented Aug 21, 2022

🦋 Changeset detected

Latest commit: 810bebc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
vfx-composer Minor
vfx-composer-r3f Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename props of createParticles return object to lowercase; also props of Particles module
1 participant