-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad parsing #12
Comments
Ugh, thanks! It's all nasty regex on the inside, I'll try tweaking it! |
Why not use a parsing library? |
It all started as a hack (you can watch my interview with Adam here). I am open to consider a parsing library, I will have to bundle it with the plugin to match the compiler versions probably... |
Oh yeah that's always the tricky thing about compiler plugins. Otherwise I would imagine the obvious choice would be the zio parsing library... Anyway I'm no expert but I'd imagine the next best way to deal with bracket pairs is recursive functions (hand parsing). I assume you're know you're looking at a ZIO and you don't care to subdivide each of the 3 arguments, you just want to correctly find the end. So I guess you could go through the string counting brackets. It shouldn't be too hard but a minimal test suite will help focus it. |
The text was updated successfully, but these errors were encountered: