Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

local links shown as missing #31

Open
firecodergithub opened this issue Sep 25, 2017 · 3 comments
Open

local links shown as missing #31

firecodergithub opened this issue Sep 25, 2017 · 3 comments

Comments

@firecodergithub
Copy link

Don't know if this is a bug or a feature, but should local links be shown with status 0? e.g. links that are missing the base url (/page.html)? I assume they're also not crawled afterwards
@firecodergithub
Copy link
Author

actually, been running now the unit tests and 2 of the 28 are failing, specifically this one with relative paths and the one with missing http( Parse_UrlOnlyRelativePath_True and Parse_UrlNoScheme_True). I'm running this from Visual Studio on Mac and running with Mono (which otherwise seems to work ok)

@firecodergithub
Copy link
Author

Raise pull request #33 for this

@tdwright
Copy link
Collaborator

Hi @firecodergithub. I'll review this ASAP. Sorry about the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tdwright @firecodergithub