Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline style attributes need refactoring #65

Open
feedmypixel opened this issue Jan 31, 2017 · 2 comments
Open

Inline style attributes need refactoring #65

feedmypixel opened this issue Jan 31, 2017 · 2 comments

Comments

@feedmypixel
Copy link
Contributor

Problem

There are a number of places where inline style attributes have been used instead of using the correct element.

Solution

Change the span elements to div elements and remove the style attributes

@rpowis
Copy link
Contributor

rpowis commented Jan 31, 2017

Tempted to say this isn't an issue because these will get removed as part of replacing the view helpers with the standardised design patterns.

The source won't even live here eventually.

@feedmypixel
Copy link
Contributor Author

feedmypixel commented Jan 31, 2017

Tempted to say this isn't an issue because these will get removed as part of replacing the view helpers with the standardised design patterns

Agreed - just wanted to document it even if potentially it had no point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants