fstr_t stack allocations is horrible and cannot be done in a single statment (FSTR_STACK_DECL)

[hnsl]

The FSTR_STACK_DECL macro is too long and makes my eyes bleed. It also a multiple assignment pattern (cancer™).

Suggested solution:

#define fstr_stack_alloc(n) ({ uint8_t _mem[n]; FSTR_PACK(_mem); })

Is the stack of the extended GCC context valid after it returns?

[simonlindholm]

Don't know, but I doubt it. Can't we just make FSTR_STACK_DECL declare the variable name you pass in?

[hnsl]

That's an option. But don't you think it's worth investigating?

Proposal:

#define fstr_stack(name, length) name; uint8_t _##name##_buf[length]; name = (fstr_t) {.len = length, .str = _##name##_buf};

fstr_t fstr_stack(foo, 2);

[simonlindholm]

I'm not convinced it's worth coming up with such complicated macros for a relatively uncommon feature, and FSTR_STACK_DECL has the advantage that it's obvious at a glance what it's doing.

[hnsl]

Okay, marking this as wontfix.