Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2065 Increase match report column size in database #2067

Merged
merged 11 commits into from
May 10, 2024

Conversation

wsbrenk
Copy link
Collaborator

@wsbrenk wsbrenk commented May 6, 2024

  1. changes proposed in this pull request:

  2. src/main/resources/release_notes.md ...

  • has been updated
  • does not require update
  1. [Optional] suggested person to review this PR @tychobrailleur

@@ -44,6 +44,17 @@ public AbstractTable(String tableName, ConnectionManager connectionManager) {
initColumns();
}

/**
* Truncate string to maximum length
* @param s String is truncated if it's length exceeds given limit
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“its”

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

urgh - fixed

* @param maxLength Length limit
* @return Truncated string
*/
static String TruncateString(String s, int maxLength) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind using lowercase for the method name? truncateString

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed - too much c++-programming in the last time....

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspected as much, there are telltale signs! ;-)
Thanks for taking the time to address this.

@wsbrenk wsbrenk merged commit 1cb63b5 into ho-dev:master May 10, 2024
1 check passed
@wsbrenk wsbrenk deleted the #2065_HO9 branch May 11, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants