-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2065 Increase match report column size in database #2067
Conversation
* ho-dev#1797 create beta * ho-dev#1797 fix build
* update release_notes.md * ho-dev#2055 remove unused info label * ho-dev#2055 remove unused info label (code analysis results) * ho-dev#2055 release_notes.md * ho-dev#2055 release_notes.md
# Conflicts: # gradle.properties
@@ -44,6 +44,17 @@ public AbstractTable(String tableName, ConnectionManager connectionManager) { | |||
initColumns(); | |||
} | |||
|
|||
/** | |||
* Truncate string to maximum length | |||
* @param s String is truncated if it's length exceeds given limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
“its”
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
urgh - fixed
* @param maxLength Length limit | ||
* @return Truncated string | ||
*/ | ||
static String TruncateString(String s, int maxLength) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind using lowercase for the method name? truncateString
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed - too much c++-programming in the last time....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspected as much, there are telltale signs! ;-)
Thanks for taking the time to address this.
changes proposed in this pull request:
src/main/resources/release_notes.md
...