You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A couple times using this library I've expected a trait to be implemented for a type when it wasn't. For example the Port type in src/model/primitives.rs doesn't implement PartialOrd/Ord, so trying to compare the port of two players to determine which comes first in the Frame<N> struct is tedious.
I don't know when ParitalOrd is sufficient or when you want PartialOrd & Ord. Same goes with ParitalEq and Eq. Seems like some types have just PartialEq when they could also have Eq. I don't know if there's a rhyme or reason why things are the way they are.
A couple times using this library I've expected a trait to be implemented for a type when it wasn't. For example the Port type in
src/model/primitives.rs
doesn't implement PartialOrd/Ord, so trying to compare the port of two players to determine which comes first in theFrame<N>
struct is tedious.I don't know when ParitalOrd is sufficient or when you want PartialOrd & Ord. Same goes with ParitalEq and Eq. Seems like some types have just PartialEq when they could also have Eq. I don't know if there's a rhyme or reason why things are the way they are.
See also: https://rust-lang.github.io/api-guidelines/interoperability.html#c-common-traits
I'd be willing to go through and add some of these to the derive statements, but it would help to hear your input.
The text was updated successfully, but these errors were encountered: