Issue-230: add load_all method to Holidays namespace to preload all d…

[ppeble]

Fixes #230

[ppeble]

I took the opportunity to remove all of the old comments in the main lib/holidays.rb file that were kind of out of date. I'm not a big fan of doc like this...they almost always become out of date. The code should self-document. If it doesn't we should address it.

[coveralls]

Coverage increased (+0.001%) to 99.476% when pulling 2623f52 on ptrimble:issue-230 into f216eda on holidays:master.

[ttwo32]

Looks good to me.:)

[espen]

are all these comments meant to be removed?

[ppeble]

Yep. They were out of date in some cases and honestly I'm not a huge fan of in-code comments like this. I believe that the code should be self-documenting and, if additional doc is needed, the README should fill in the gaps.

Thoughts? Was this kind of documentation useful to you? I'm open to discussing it, although I would want to re-add it in another PR/issue so that they are up to date if we do go that route.

[espen]

I just thought maybe it was a mistake since it was committed with this patch. I guess it's covered in the readme. I think it's fine for this project with not so many methods, for larger projects like Rails I think inline commenting is useful.

[ppeble]

Fair point. I'm not as anti-comment as some of my coworkers (who refuse to allow any of them, ever). I bet that you and I are probably pretty close on what we would find 'acceptable'.

In this case I'll merge this and think about the best way to document for future developers.

Thanks!