Fix comment syntax in MySQL parser #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+459
to
+460
| = "COMMENT"i _ ("=" _)? comment: "'" c:[^']* "'" {return c.join('')} | ||
| / "COMMENT"i _ ("=" _)? comment: "\"" c:[^"]* "\"" {return c.join('')} |
There was a problem hiding this comment.
If we disregard this word's case sensitivity, are there any problems?
I'm not sure why we didn't ignore the case sensitive here earlier; I just want to learn it.
There was a problem hiding this comment.
There is no issue. We forgot to ignore the case sensitive for this token in the past 🙏
Most of the SQL keywords are case-insensitive so it's better if we can parse the keywords correctly.
There was a problem hiding this comment.
Try to create another Asana task to list the remaining keywords that tie in to these same problems. It could be brought up again for future updates.
huyphung1602
approved these changes
Oct 16, 2023
nguyenalter
added
the
PR: Bug Fix 🐛
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix comment syntax in MySQL parser
Issue
Lasting Changes (Technical)
COMMENTtokenChecklist
Please check directly on the box once each of these are done