rsync plugin + documentation #122
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added username/password explanation. Fixed default rsync options.
Semi because having trouble getting Python to build the option correctly. So it currently does not work.
Otherwise I was having issues getting the deb packages to build.
It can be quite expensive for large directories and the old method did not account for not crossing file-systems.
Updated check_available_space in holland.core.backup to allow for plugins to specify None as the estimated backup size (basically skipping space checking). rsync plugin now supports SSH ports and keys finally. Also per the above, skips space estimation entirely. Added config documentation for rsync port, keyfile, and bandwidth-limit settings.
Removed 'estimated-size-factor' in codeblock under Backup-Set Configs since it's technically optional and now not relevant for some plugins (basically 'rsync').
* Expanded the provider/backup-set concept a bit. * Replaced a version number with |version|
Pulled providers into their own section to better explain the capabilities of each one. Changed the headings to split up configuring the plugin versus explaining what the plugin does.
|
I apologize I haven't given this enough of a look over. I will be releasing 1.0.12 soon, so I am going to defer merging this until post 1.0.12. This holland-tar contribution gave me some heartburn, so I want to take some time to look this over in more detail before pulling it in. |
|
Yup understood! The plugin itself works pretty well at least for me uses but if the tar plugin had some annoyances it's certainly possible this one does too ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I should have put these in two pulls but basically worked on 2 things:
rsync plugin:
For doing differential style backups using rsync, leveraging hard-links. I'm not trying to pressure this to go into mainline but wasn't sure otherwise how best to handle it as a 3rd party plugin outside of the tree. I've been using it for a while now for my own backups, though I'd consider this beta. Additionally, it could use some extra features (such as a way to set nice/ionice, although I wonder if that may be useful as a holland core config option).
Docs:
I didn't like how we were organizing provider configuration information under the main configuration section. Instead, I pulled out providers into their own section, where we can elaborate on what they do, and put references to them in the config section instead. I think it is much better.
Both of these are merely proposals. Probably worthy of more discussion in holland-discuss, but since I was going out of town for the weekend, I thought I'd go ahead and toss this out in case if was needed.