Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appInfo request returns null if app not found #232

Closed
matthme opened this issue Feb 26, 2024 · 1 comment
Closed

appInfo request returns null if app not found #232

matthme opened this issue Feb 26, 2024 · 1 comment

Comments

@matthme
Copy link
Contributor

matthme commented Feb 26, 2024

According to the function signature of AppWebsocket.appInfo I expect to get a Promise<AppInfo>, i.e. that the call would fail if there is no app installed with the given installed_app_id. However if there is no app installed with the given id the call succeeds and returns null. Either this should be documented in the function signature (i.e. Promise<AppInfo | null>) or the Promise should reject.

@jost-s
Copy link
Contributor

jost-s commented Feb 27, 2024

Thanks for raising this.

The conductor returns an optional AppInfo indeed https://docs.rs/holochain_conductor_api/0.2.5/holochain_conductor_api/enum.AppResponse.html#variant.AppInfo

I'll see if I can bend the client code to use AppInfo | null : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants