Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

40 add test command #45

Merged
merged 11 commits into from
Oct 5, 2018
Merged

40 add test command #45

merged 11 commits into from
Oct 5, 2018

Conversation

Connoropolous
Copy link
Collaborator

@Connoropolous Connoropolous commented Oct 3, 2018

It's working!

Implements hcdev test

closes #40
builds off #44

What it does:

  1. builds the files into a Genome bundle
  2. in the test folder, install node_modules if necessary
  3. runs webpack build step, to convert from ES6 to ES5 js
  4. runs the tests using holoconsole command, which know where to look for the Genome bundle

screen shot 2018-10-04 at 3 55 42 pm

@Connoropolous Connoropolous self-assigned this Oct 3, 2018
@Connoropolous Connoropolous changed the base branch from master to 41-add-test-folder October 3, 2018 22:34
@zippy
Copy link
Member

zippy commented Oct 4, 2018

I would like to recommend that we rename the command in this repo to plain old hc. For now, in advance of actually having different excecutables for the different sub-parts of hc (as we should end up) lets just have one command. Also, from what I see in the devcamp there's the idea that folk will actually be installing holochain-proto as well as holochain-rust based tools, and if that's the case we really need to not have the hcdev name collision.

@Connoropolous
Copy link
Collaborator Author

Sounds good @zippy ... we have #27 open for that

@Connoropolous Connoropolous changed the title WIP: 40 add test command 40 add test command Oct 4, 2018
Copy link
Member

@zippy zippy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I just added a bit into the readme regarding dependencies.

@zippy zippy merged commit bd81ad2 into 41-add-test-folder Oct 5, 2018
@zippy zippy removed the review label Oct 5, 2018
@Connoropolous Connoropolous deleted the 40-add-test-command branch October 5, 2018 21:40
@Connoropolous Connoropolous mentioned this pull request Oct 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants