Skip to content
This repository has been archived by the owner on Sep 15, 2020. It is now read-only.

js zome config returnErrors:bool->ErrorHandling:str, closes #588 #591

Merged
merged 2 commits into from
Mar 6, 2018

Conversation

zippy
Copy link
Member

@zippy zippy commented Mar 2, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 5, 2018

Codecov Report

Merging #591 into develop will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #591      +/-   ##
===========================================
+ Coverage     72.1%   72.13%   +0.02%     
===========================================
  Files           40       40              
  Lines         9522     9530       +8     
===========================================
+ Hits          6866     6874       +8     
+ Misses        1894     1893       -1     
- Partials       762      763       +1
Impacted Files Coverage Δ
holochain.go 76.12% <ø> (ø) ⬆️
jsribosome.go 76.71% <100%> (+0.77%) ⬆️
kad_table.go 84.02% <0%> (-4.17%) ⬇️
node.go 71.81% <0%> (+0.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7a07bf...4596032. Read the comment docs.

Copy link
Contributor

@philipbeadle philipbeadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Config": {
"ErrorHandling": "returnErrorValue"
},
1:49 PM
or
"Config": {
"ErrorHandling": "throwErrors"
},

@philipbeadle philipbeadle merged commit 8d6926f into develop Mar 6, 2018
@philipbeadle philipbeadle deleted the 588-change-throw-errs-config branch March 6, 2018 03:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants