Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faulty grid lines handling #343

Closed
poplarShift opened this issue Jul 25, 2019 · 1 comment
Closed

Faulty grid lines handling #343

poplarShift opened this issue Jul 25, 2019 · 1 comment

Comments

@poplarShift
Copy link

Before #308, the following failed:

import holoviews as hv
hv.extension('matplotlib')
import geoviews as gv # without this, works

(hv.Scatter([]) * hv.Scatter([])).opts(show_grid=True)

as was already noted in #307.
A similar issue is also at work in #332

However, the patch employed in #308, and my current draft of #332, (replacing cartopy's GeoAxes gridlines method with standard mpl grid) removes all the benefits of having cartopy handle the grid lines in the first place...

So what would be needed is some sort of logic that decides whether the elements in question are, in fact, GeoViews objects (or whether the Overlay is composed of actual geo objects), and hence if they are GeoAxes or just plain matplotlib ones; and THEN accordingly apply gridlines or grid.

@poplarShift poplarShift changed the title Faulty grid lines handling in geoviews Faulty grid lines handling Jul 25, 2019
@philippjfr
Copy link
Member

philippjfr commented Oct 8, 2019

Merged #351 which appears to have fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants