Param 2: allow Dataset to have any number of kdims
#626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does it make sense to have none kdims? If it does, you can just merge this PR. If not, I suggest updating the bounds to |
|
https://github.com/holoviz/holoviews/blob/main/holoviews/core/dimension.py#L815 I don't know if it makes sense though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #624, in preparation of Param 2.
kdims.boundswas inherited from_Elementwith a value of(2, 2), which appeared not to be valid forDataset. Running the notebooks pointed out in the issue, I saw thatDatasetcould have morekdimsthan 2. I was also slightly surprised to see that it could have less than 2, I got an error wherekdimswas just[Dimension('time')]. I decided to letkdimsaccept any number of dimensions, i.e.bounds=(0, None), as this anyway the default value in Param 1.