Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send None values to the database when adding new rows #92

Merged
merged 12 commits into from
Jan 23, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 15, 2023

This PR does the following:

  • Don't send None values to the database when adding rows. This is already done by the database.
  • Remove the columns property.
  • Fixes a bug where AnnotatorInterface did not clear the region after adding an annotation, this bug did not affect the Annotator when using an element.

Based on the use_context PR.

Copy link

codspeed-hq bot commented Dec 15, 2023

CodSpeed Performance Report

Merging #92 will not alter performance

Comparing dont_make_non_columns (fba322b) with main (039754b)

Summary

✅ 6 untouched benchmarks

Base automatically changed from use_context to main January 22, 2024 18:23
@hoxbro hoxbro merged commit 41ba8ad into main Jan 23, 2024
17 checks passed
@hoxbro hoxbro deleted the dont_make_non_columns branch January 23, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant