Skip to content

Commit

Permalink
Attempt to fix ffmpeg export (#3513)
Browse files Browse the repository at this point in the history
  • Loading branch information
philippjfr committed Feb 21, 2019
1 parent 99edeb2 commit 47d5b10
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 14 deletions.
15 changes: 2 additions & 13 deletions holoviews/tests/plotting/matplotlib/testrenderer.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,20 +65,9 @@ def test_get_size_table(self):
self.assertEqual((w, h), (288, 288))

def test_render_gif(self):
try:
data, metadata = self.renderer.components(self.map1, 'gif')
except IndexError:
# ignore linux issues temporarily
# self._frames[0].save(
# IndexError: list index out of range
return
data, metadata = self.renderer.components(self.map1, 'gif')
self.assertIn("<img src='data:image/gif", data['text/html'])

def test_render_mp4(self):
try:
data, metadata = self.renderer.components(self.map1, 'mp4')
except ValueError:
# ignore linux issues temporarily
# ValueError: I/O operation on closed file
return
data, metadata = self.renderer.components(self.map1, 'mp4')
self.assertIn("<source src='data:video/mp4", data['text/html'])
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
extras_require['examples'] = extras_require['recommended'] + [
'networkx', 'pillow', 'xarray>=0.10.4', 'plotly>=3.4',
'datashader', 'selenium', 'phantomjs', 'ffmpeg', 'streamz>=0.5.0',
'cftime', 'netcdf4']
'cftime', 'netcdf4', 'bzip2']

# Extra third-party libraries
extras_require['extras'] = extras_require['examples']+[
Expand Down

0 comments on commit 47d5b10

Please sign in to comment.