Preserve cols when overlaying on layout

holoviz · Nov 16, 2021 · f835751 · f835751
1 parent 403c1aa
commit f835751
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/holoviews/core/layout.py b/holoviews/core/layout.py
@@ -570,7 +570,9 @@ def __mul__(self, other, reverse=False):
         from .spaces import HoloMap
         if not isinstance(other, (ViewableElement, HoloMap)):
             return NotImplemented
-        return Layout([other*v if reverse else v*other for v in self])
+        layout = Layout([other*v if reverse else v*other for v in self])
+        layout._max_cols = self._max_cols
+        return layout
 
     def __rmul__(self, other):
         return self.__mul__(other, reverse=True)

diff --git a/holoviews/tests/core/test_layouts.py b/holoviews/tests/core/test_layouts.py
@@ -29,6 +29,12 @@ def test_add_unicode(self):
         elements = list(layout)
         self.assertEqual(len(elements), 2)
 
+    def test_layout_overlay_ncols_preserved(self):
+        assert ((self.view1 + self.view2).cols(1) * self.view3)._max_cols == 1
+
+    def test_layout_rmul_overlay_ncols_preserved(self):
+        assert (self.view3 * (self.view1 + self.view2).cols(1))._max_cols == 1
+
 
 class AdjointLayoutTest(CompositeTest):