Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hv.Cycle does not cycle through markers for bokeh backend #3706

Closed
poplarShift opened this issue May 13, 2019 · 4 comments
Closed

hv.Cycle does not cycle through markers for bokeh backend #3706

poplarShift opened this issue May 13, 2019 · 4 comments
Milestone

Comments

@poplarShift
Copy link
Collaborator

@poplarShift poplarShift commented May 13, 2019

In the bokeh backend, only the first marker of the list seems to be used:

import holoviews as hv
import numpy as np
hv.extension('bokeh')
s1 = hv.Dataset(np.random.rand(100,3), ['x', 'y'], 'z'
          ).to(hv.Scatter).overlay().opts(hv.opts.Scatter(size=hv.Cycle([8,15,30]), marker='<'))
s2 = hv.Dataset(np.random.rand(100,3), ['x', 'y'], 'z'
          ).to(hv.Scatter).overlay().opts(hv.opts.Scatter(size=10, marker=hv.Cycle(['cross', 'square', '<'])))

s1+s2

Screen Shot 2019-05-13 at 11 26 05 AM

Compare to mpl where everything seems ok:

Screen Shot 2019-05-13 at 11 26 16 AM

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 13, 2019

This is related to the batching optimization in the bokeh backend which merges multiple overlays into a single glyph because it is very inefficient to draw a lot of individual glyphs. When this optimization was first introduced it was not possible to cycle markers but since then this has become possible so we should be able to fix this pretty easily.

@poplarShift
Copy link
Collaborator Author

@poplarShift poplarShift commented May 13, 2019

Where does the application of Cycle live?

@philippjfr
Copy link
Member

@philippjfr philippjfr commented May 13, 2019

Got a fix in #3707

@poplarShift
Copy link
Collaborator Author

@poplarShift poplarShift commented May 13, 2019

Even better, thanks a lot!

@philippjfr philippjfr added this to the v1.12.3 milestone May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

2 participants