New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generalized hashing of keys for memoization #1074
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
166e951
Added HashGenerator and keyhash function to core.util
jlstevens 17d93ff
Callable now memoizes on the util.keyhash value of the key
jlstevens 10f6440
Skipping memoization if key hashing fails
jlstevens 3b85f34
Updated docstring of HashGenerator
jlstevens a474cac
Renamed HashGenerator to HashableJSON
jlstevens cc655f0
Renamed core.util.keyhash to deephash
jlstevens 2d6fd2d
Removed as_string optional argument of deephash
jlstevens 78c3953
Renamed 'key' argument of deephash to 'obj'
jlstevens c7225fe
Simplified deephash definition
jlstevens 2636055
Added 17 deephash unit tests
jlstevens 7ac04a5
Updated HashableJSON docstring
jlstevens d597fe1
Fix for Python 3 compatibility
jlstevens adcc5cb
Using repr for pandas objects for Python 3 compatibility
jlstevens c1cd64e
Removed heterogeneous keys incompatible with Python 3
jlstevens File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and custom mutable